From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091
Date: Wed, 12 Oct 2011 09:40:10 +1100 [thread overview]
Message-ID: <20111011224010.GG3159@dastard> (raw)
In-Reply-To: <20111010182216.GA1335@infradead.org>
On Mon, Oct 10, 2011 at 02:22:16PM -0400, Christoph Hellwig wrote:
> This effectively reverts
>
> xfstests: add mapped write fsx operations to 091
>
> and adds a new test case for it. It tests something slightly different, and
> regressions in existing tests due to new features are pretty nasty in a
> test suite.
Makes sense.
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests-dev/263
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ xfstests-dev/263 2011-10-10 18:06:59.000000000 +0000
> @@ -0,0 +1,64 @@
> +#! /bin/bash
> +# FS QA Test No. 263
> +#
> +# fsx exercising direct IO vs sub-block buffered I/O
> +#
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2000-2004 Silicon Graphics, Inc. All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +#
> +#-----------------------------------------------------------------------
> +#
> +# creator
> +owner=nathans@sgi.com
No point keeping an invalid email address as the owner of a new
test.
FWIW, I'm considering removing this from the tests as the
information is in the commit history, and the use of the field
(emailing the owner when the automated test infrastructure SGI used
10 years ago failed) is no longer used...
Otherwise looks OK.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-11 22:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 18:21 [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Christoph Hellwig
2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
2011-10-10 18:22 ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
2011-10-11 2:11 ` Dave Chinner
2011-10-11 12:46 ` Christoph Hellwig
2011-10-11 14:18 ` [PATCH 3/3 v2] " Christoph Hellwig
2011-10-11 22:40 ` Dave Chinner
2011-10-13 11:06 ` Alex Elder
2011-10-11 22:40 ` Dave Chinner [this message]
2011-10-12 7:32 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
2011-10-13 11:06 ` Alex Elder
2011-10-13 11:06 ` Alex Elder
2011-10-11 22:36 ` [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Dave Chinner
2011-10-13 11:06 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011224010.GG3159@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox