From: Christoph Hellwig <hch@infradead.org>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC v2 PATCH 1/5] xfs: Prep work for supporting both pquota and gquota.
Date: Thu, 27 Oct 2011 12:17:24 -0400 [thread overview]
Message-ID: <20111027161724.GA30209@infradead.org> (raw)
In-Reply-To: <20111026212158.6513.17142.sendpatchset@chandra-lucid.austin.ibm.com>
On Wed, Oct 26, 2011 at 04:21:58PM -0500, Chandra Seetharaman wrote:
> Define few macros, inline functions, and change interface in
> preparation for allowing pquota and gquota to be used together.
Looks good, but I'd really prefer to split this up further:
- one patch for adding xfs_inode_dquot
- one patch for adding XFS_IS_TYPE_QUOTA_ON
(which I'd rather make an inline and call xfs_this_quota_on)
- one for passing the mount structure to xfs_sb_from_disk
- one for the quota flags changes.
All of these also should have a good changelog, most importantly the flag
changes. If you can repost just these changes relatively soon please do
so, as I have a huge series for the quota code that should go into the
3.2 tree which I need to rebase anyway, and I'd like to do it on top of
your changes.
> - xfs_sb_t *to,
> + xfs_mount_t *mp,
> xfs_dsb_t *from)
> {
> + xfs_sb_t *to = &mp->m_sb;
> +
For code you touch please always use the struct versions instead of
the typedefs for lines you change anyway or add.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-27 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 21:21 [RFC v2 PATCH 0/5] xfs: Allow pquota and gquota to be used together Chandra Seetharaman
2011-10-26 21:21 ` [RFC v2 PATCH 1/5] xfs: Prep work for supporting both pquota and gquota Chandra Seetharaman
2011-10-27 16:17 ` Christoph Hellwig [this message]
2011-10-27 18:12 ` Chandra Seetharaman
2011-10-26 21:22 ` [RFC v2 PATCH 2/5] xfs: Remove incore use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD Chandra Seetharaman
2011-10-26 21:22 ` [RFC v2 PATCH 3/5] xfs: Add pquota fields where gquota is used Chandra Seetharaman
2011-10-26 21:22 ` [RFC v2 PATCH 4/5] xfs: Add pquotaino to on-disk super block Chandra Seetharaman
2011-10-26 21:22 ` [RFC v2 PATCH 5/5] xfs: Add a new field to fs_quota_stat to get pquota information Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027161724.GA30209@infradead.org \
--to=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox