From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p9RGHTR9104858 for ; Thu, 27 Oct 2011 11:17:30 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C47C81FCD0E for ; Thu, 27 Oct 2011 09:17:27 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id 4UoFSc1GCBIAWVHw for ; Thu, 27 Oct 2011 09:17:27 -0700 (PDT) Date: Thu, 27 Oct 2011 12:17:24 -0400 From: Christoph Hellwig Subject: Re: [RFC v2 PATCH 1/5] xfs: Prep work for supporting both pquota and gquota. Message-ID: <20111027161724.GA30209@infradead.org> References: <20111026212150.6513.38058.sendpatchset@chandra-lucid.austin.ibm.com> <20111026212158.6513.17142.sendpatchset@chandra-lucid.austin.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111026212158.6513.17142.sendpatchset@chandra-lucid.austin.ibm.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Chandra Seetharaman Cc: xfs@oss.sgi.com On Wed, Oct 26, 2011 at 04:21:58PM -0500, Chandra Seetharaman wrote: > Define few macros, inline functions, and change interface in > preparation for allowing pquota and gquota to be used together. Looks good, but I'd really prefer to split this up further: - one patch for adding xfs_inode_dquot - one patch for adding XFS_IS_TYPE_QUOTA_ON (which I'd rather make an inline and call xfs_this_quota_on) - one for passing the mount structure to xfs_sb_from_disk - one for the quota flags changes. All of these also should have a good changelog, most importantly the flag changes. If you can repost just these changes relatively soon please do so, as I have a huge series for the quota code that should go into the 3.2 tree which I need to rebase anyway, and I'd like to do it on top of your changes. > - xfs_sb_t *to, > + xfs_mount_t *mp, > xfs_dsb_t *from) > { > + xfs_sb_t *to = &mp->m_sb; > + For code you touch please always use the struct versions instead of the typedefs for lines you change anyway or add. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs