From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: replace i_pin_wait with a bit waitqueue
Date: Thu, 27 Oct 2011 12:42:29 -0400 [thread overview]
Message-ID: <20111027164229.GA18033@infradead.org> (raw)
In-Reply-To: <1319663253.5239.75.camel@doink>
On Wed, Oct 26, 2011 at 04:07:33PM -0500, Alex Elder wrote:
> > + xfs_iunpin(ip);
> > +
>
> This initially struck me as unsafe or something,
> assuming the inode was pinned. But I was thinking
> of it more like an unlock request, which it is not.
> It's more like unplugging something so the inode
> will eventually get unpinned. (Just thinking aloud
> here, nevermind me...)
After the next series I am about to post there will be just one caller of
xfs_iunpin left. We can probably simply fold it at that point.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-27 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 18:23 [PATCH 0/4] inode diet, part1 V2 Christoph Hellwig
2011-10-19 18:23 ` [PATCH 1/4] xfs: make i_flags and unsigned long Christoph Hellwig
2011-10-26 21:07 ` Alex Elder
2011-10-19 18:23 ` [PATCH 2/4] xfs: replace i_flock with a sleeping bitlock Christoph Hellwig
2011-10-26 21:07 ` Alex Elder
2011-10-19 18:23 ` [PATCH 3/4] xfs: replace i_pin_wait with a bit waitqueue Christoph Hellwig
2011-10-26 21:07 ` Alex Elder
2011-10-27 16:42 ` Christoph Hellwig [this message]
2011-10-19 18:23 ` [PATCH 4/4] xfs: remove the unused dm_attrs structure Christoph Hellwig
2011-10-26 21:07 ` Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2011-10-18 20:13 [PATCH 0/4] inode diet, part1 Christoph Hellwig
2011-10-18 20:13 ` [PATCH 3/4] xfs: replace i_pin_wait with a bit waitqueue Christoph Hellwig
2011-10-19 0:50 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027164229.GA18033@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox