From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: fix metadata restore on split files
Date: Fri, 28 Oct 2011 05:37:16 -0400 [thread overview]
Message-ID: <20111028093716.GA23069@infradead.org> (raw)
In-Reply-To: <1319671483-27787-1-git-send-email-wkendall@sgi.com>
On Wed, Oct 26, 2011 at 06:24:43PM -0500, Bill Kendall wrote:
> xfsrestore does not apply certain metadata until all of the file's
> data has been restored. This allows, for example, files with the
> immutable flag set to be restored properly.
>
> While testing multi-stream restores, I noticed that files split
> across multiple streams did not have their metadata restored.
> Looking into this further, it also applies to the single-stream
> case where files are split across media files, such as when a
> backup spans multiple tapes.
>
> The fix is to check to see if a file is completely restored
> whenever we hit the end of a media file. The current code
> is broken because it relies on all media files being applied
> during the same restore session.
>
> This also moves the S_ISREG() check into restore_complete_reg()
> rather than relying on callers to make the check.
Uhh, that's a nasty bug for people storing large files over multiple
tapes. Any chance we could get an xfstests test case for this?
Can we somehow simulate multiple tapes using small files?
The code change looks okay to me, but I have to admit I don't really
understand the code very well.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-28 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 23:24 [PATCH] xfsdump: fix metadata restore on split files Bill Kendall
2011-10-28 9:37 ` Christoph Hellwig [this message]
2011-10-28 13:35 ` Bill Kendall
2011-10-31 12:14 ` Bill Kendall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028093716.GA23069@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox