From: Christoph Hellwig <hch@infradead.org>
To: Boris Ranto <branto@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <esandeen@redhat.com>, xfs <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version
Date: Fri, 28 Oct 2011 05:53:54 -0400 [thread overview]
Message-ID: <20111028095354.GA1062@infradead.org> (raw)
In-Reply-To: <be02ada1-aee5-406d-84cd-d54dde7ae871@zmail16.collab.prod.int.phx2.redhat.com>
On Fri, Oct 28, 2011 at 05:38:06AM -0400, Boris Ranto wrote:
> The test 016 fills scratch device with some data and then creates xfs fs
> on the scratch device. Later, the test assumes that the previously
> written data are still written there and checks for them at specific
> locations. On ssd drive this will lead to a failure since the blocks are
> discarded by default when the mkfs command is run.
> This is a more verbose version of the previous patch.
> This simple patch that adds -K to stop the discarding (if the mkfs
> command supports it) fixed the issue for me:
>
> Signed-off-by: Boris Ranto <branto@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-28 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 10:46 [PATCH] xfstests 016: Do not discard blocks at the mkfs time Boris Ranto
2011-10-27 16:04 ` Christoph Hellwig
2011-10-28 9:25 ` Boris Ranto
2011-10-28 9:38 ` [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version Boris Ranto
2011-10-28 9:53 ` Christoph Hellwig [this message]
2012-05-29 16:54 ` Eric Sandeen
2012-05-30 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028095354.GA1062@infradead.org \
--to=hch@infradead.org \
--cc=branto@redhat.com \
--cc=esandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox