From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p9S9ruHP145014 for ; Fri, 28 Oct 2011 04:53:57 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 30F9D161DB50 for ; Fri, 28 Oct 2011 02:53:55 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id re57bf8CfmCH5EbP for ; Fri, 28 Oct 2011 02:53:55 -0700 (PDT) Date: Fri, 28 Oct 2011 05:53:54 -0400 From: Christoph Hellwig Subject: Re: [PATCH] xfstests 016: Do not discard blocks at the mkfs time, more verbose version Message-ID: <20111028095354.GA1062@infradead.org> References: <1319625983.3074.28.camel@dhcp-26-208.brq.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Boris Ranto Cc: Christoph Hellwig , Eric Sandeen , xfs On Fri, Oct 28, 2011 at 05:38:06AM -0400, Boris Ranto wrote: > The test 016 fills scratch device with some data and then creates xfs fs > on the scratch device. Later, the test assumes that the previously > written data are still written there and checks for them at specific > locations. On ssd drive this will lead to a failure since the blocks are > discarded by default when the mkfs command is run. > This is a more verbose version of the previous patch. > This simple patch that adds -K to stop the discarding (if the mkfs > command supports it) fixed the issue for me: > > Signed-off-by: Boris Ranto Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs