From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH 02/45] xfs: make i_flags an unsigned long
Date: Fri, 28 Oct 2011 05:54:25 -0400 [thread overview]
Message-ID: <20111028100335.744099698@bombadil.infradead.org> (raw)
In-Reply-To: 20111028095423.796574703@bombadil.infradead.org
[-- Attachment #1: xfs-use-i_flags --]
[-- Type: text/plain, Size: 1314 bytes --]
To be used for bit wakeup i_flags needs to be an unsigned long or we'll
run into trouble on big endian systems. Beause of the 1-byte i_update
field right after it this actually causes a fairly large size increase
on its own (4 or 8 bytes), but that increase will be more than offset
by the next two patches.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/xfs_inode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: xfs/fs/xfs/xfs_inode.h
===================================================================
--- xfs.orig/fs/xfs/xfs_inode.h 2011-10-27 22:39:37.020671981 +0200
+++ xfs/fs/xfs/xfs_inode.h 2011-10-27 22:39:52.102172907 +0200
@@ -249,7 +249,7 @@ typedef struct xfs_inode {
wait_queue_head_t i_ipin_wait; /* inode pinning wait queue */
spinlock_t i_flags_lock; /* inode i_flags lock */
/* Miscellaneous state. */
- unsigned short i_flags; /* see defined flags below */
+ unsigned long i_flags; /* see defined flags below */
unsigned char i_update_core; /* timestamps/size is dirty */
unsigned int i_delayed_blks; /* count of delay alloc blks */
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-28 10:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 9:54 [PATCH 00/45] write back all metadata via the AIL (and remove xfsbufd) Christoph Hellwig
2011-10-28 9:54 ` [PATCH 01/45] xfs: constify xfs_item_ops Christoph Hellwig
2011-10-28 9:54 ` Christoph Hellwig [this message]
2011-10-28 9:54 ` [PATCH 03/45] xfs: replace i_flock with a sleeping bitlock Christoph Hellwig
2011-10-28 9:54 ` [PATCH 04/45] xfs: replace i_pin_wait with a bit waitqueue Christoph Hellwig
2011-10-28 9:54 ` [PATCH 05/45] xfs: remove the unused dm_attrs structure Christoph Hellwig
2011-10-28 9:54 ` [PATCH 06/45] xfs: remove xfs_itruncate_data Christoph Hellwig
2011-10-28 9:54 ` [PATCH 07/45] xfs: cleanup xfs_iomap_eof_align_last_fsb Christoph Hellwig
2011-10-28 9:54 ` [PATCH 08/45] xfs: remove the i_size field in struct xfs_inode Christoph Hellwig
2011-10-28 9:54 ` [PATCH 09/45] xfs: remove the i_new_size " Christoph Hellwig
2011-10-28 9:54 ` [PATCH 10/45] fix: force shutdown handling in xfs_end_io Christoph Hellwig
2011-11-05 8:11 ` Christoph Hellwig
2011-10-28 9:54 ` [PATCH 11/45] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-10-28 9:54 ` [PATCH 12/45] xfs: do not require an ioend for new EOF calculation Christoph Hellwig
2011-10-28 9:54 ` [PATCH 16/45] xfs: untange SYNC_WAIT and SYNC_TRYLOCK meanings for xfs_qm_dqflush Christoph Hellwig
2011-10-28 9:54 ` [PATCH 17/45] xfs: make sure to really flush all dquots in xfs_qm_quotacheck Christoph Hellwig
2011-10-28 9:54 ` [PATCH 18/45] xfs: remove xfs_qm_sync Christoph Hellwig
2011-10-28 9:54 ` [PATCH 19/45] xfs: remove the sync_mode argument to xfs_qm_dqflush_all Christoph Hellwig
2011-10-28 9:54 ` [PATCH 20/45] xfs: cleanup dquot locking helpers Christoph Hellwig
2011-10-28 9:54 ` [PATCH 21/45] xfs: cleanup xfs_qm_dqlookup Christoph Hellwig
2011-10-28 9:54 ` [PATCH 22/45] xfs: remove XFS_DQ_INACTIVE Christoph Hellwig
2011-10-28 9:54 ` [PATCH 23/45] xfs: implement lazy removal for the dquot freelist Christoph Hellwig
2011-10-28 9:54 ` [PATCH 24/45] xfs: flatten the dquot lock ordering Christoph Hellwig
2011-10-28 9:54 ` [PATCH 25/45] xfs: nest the qm_dqfrlist_lock insise the dquot qlock Christoph Hellwig
2011-10-28 9:54 ` [PATCH 26/45] xfs: simplify xfs_qm_dqattach_grouphint Christoph Hellwig
2011-10-28 9:54 ` [PATCH 27/45] xfs: add a xfs_dqhold helper Christoph Hellwig
2011-10-28 9:54 ` [PATCH 28/45] xfs: kill xfs_qm_dqinit_core Christoph Hellwig
2011-10-28 9:54 ` [PATCH 29/45] xfs: kill xfs_qm_idtodq Christoph Hellwig
2011-10-28 9:54 ` [PATCH 30/45] xfs: remove XFS_QMOPT_DQSUSER Christoph Hellwig
2011-10-28 9:54 ` [PATCH 31/45] xfs: simplify xfs_qm_detach_gdquots Christoph Hellwig
2011-10-28 9:54 ` [PATCH 32/45] xfs: use a normal shrinker for the dquot freelist Christoph Hellwig
2011-10-28 9:54 ` [PATCH 33/45] xfs: reclaim clean dquots first Christoph Hellwig
2011-10-28 9:54 ` [PATCH 34/45] xfs: do flush inodes during asynchronous inode reclaim Christoph Hellwig
2011-10-28 9:54 ` [PATCH 35/45] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown Christoph Hellwig
2011-10-28 9:54 ` [PATCH 36/45] xfs: remove log item from AIL in xfs_iflush " Christoph Hellwig
2011-10-28 9:55 ` [PATCH 37/45] xfs: implement freezing by emptying the AIL Christoph Hellwig
2011-10-28 9:55 ` [PATCH 38/45] xfs: explicitly empty the AIL on unmount Christoph Hellwig
2011-10-28 9:55 ` [PATCH 39/45] xfs: do not write the buffer from xfs_iflush Christoph Hellwig
2011-10-28 9:55 ` [PATCH 40/45] xfs: do not write the buffer from xfs_qm_dqflush Christoph Hellwig
2011-10-28 9:55 ` [PATCH 41/45] xfs: do not add buffers to the delwri queue until pushed Christoph Hellwig
2011-10-28 9:55 ` [PATCH 42/45] xfs: on-stack delayed write buffer lists Christoph Hellwig
2011-10-28 9:55 ` [PATCH 43/45] xfs: do not try to unpin the inode buffer in xfs_iflush Christoph Hellwig
2011-10-28 9:55 ` [PATCH 44/45] xfs: do not try to unpin the inode buffer in xfs_qm_dq_flush Christoph Hellwig
2011-10-28 9:55 ` [PATCH 45/45] xfs: force the log in xfs_buf_wait_unpin Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028100335.744099698@bombadil.infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox