From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pA38XA7u250718 for ; Thu, 3 Nov 2011 03:33:10 -0500 Date: Thu, 3 Nov 2011 04:33:09 -0400 From: Christoph Hellwig Subject: Re: [PATCH 7/8] xfsdump: path lookup cache must be thread specific Message-ID: <20111103083309.GF11854@infradead.org> References: <1320268254-20583-1-git-send-email-wkendall@sgi.com> <1320268254-20583-8-git-send-email-wkendall@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1320268254-20583-8-git-send-email-wkendall@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Bill Kendall Cc: xfs@oss.sgi.com On Wed, Nov 02, 2011 at 04:10:53PM -0500, Bill Kendall wrote: > The xfsrestore path lookup routine (maps an ino + generation number to a > pathname) contains a cache for fast lookups of consecutive files in the > same parent directory. This cache either needs to be protected by a lock > or a cache is needed per thread. I took the latter approach since it > doesn't add lock contention and it increases the cache hit rate (it's > relatively unlikely that each stream is processing files in the same > directory). > > Signed-off-by: Bill Kendall Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs