From: Christoph Hellwig <hch@infradead.org>
To: Amit Sahrawat <amit.sahrawat83@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [Patch] xfs: serialise unaligned direct IOs
Date: Thu, 3 Nov 2011 06:06:47 -0400 [thread overview]
Message-ID: <20111103100647.GA1002@infradead.org> (raw)
In-Reply-To: <CADDb1s3UN4HMKEA2kSEM0HsUCC7DE63B1oJAoL6QpqXBdDCEqQ@mail.gmail.com>
On Thu, Nov 03, 2011 at 03:29:18PM +0530, Amit Sahrawat wrote:
> > You probably should keep the original Signoff and reviewed-by tags,
> > and add your editor note on the top into [ ] ?brackets.
> Ok, will do so in the final patch. Actually was unaware of information
> to keep in backported patches?
The standard procedure is to keep patches basically as-is. This doesn't
quite apply for your case, so I think just adding a comment in
[ ] brackets on the top is the best you can do.
> > You also need to make the i_mutex unlock and need_i_mutex update
> > conditional here, otherwise you still serialize all O_DIRECT writes.
> >
> you mean, keeping need_i_mutex=0 and mutex_unlock as part of 'else' statement.
Yes.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-03 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 6:07 [Patch] xfs: serialise unaligned direct IOs Amit Sahrawat
2011-11-03 7:02 ` Christoph Hellwig
2011-11-03 9:59 ` Amit Sahrawat
2011-11-03 10:06 ` Christoph Hellwig [this message]
2011-11-03 11:19 ` Amit Sahrawat
2011-12-12 14:34 ` Christoph Hellwig
2011-12-14 8:57 ` Amit Sahrawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111103100647.GA1002@infradead.org \
--to=hch@infradead.org \
--cc=amit.sahrawat83@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox