From: Christoph Hellwig <hch@infradead.org>
To: Eryu Guan <guaneryu@gmail.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: meet btrfs fs size requirement in _scratch_mkfs_sized()
Date: Fri, 4 Nov 2011 01:39:08 -0400 [thread overview]
Message-ID: <20111104053908.GB16720@infradead.org> (raw)
In-Reply-To: <1320374284-1534-2-git-send-email-guaneryu@gmail.com>
On Fri, Nov 04, 2011 at 10:38:04AM +0800, Eryu Guan wrote:
> btrfs requires at least 256M file system size, so check 'fssize' in
> _scratch_mkfs_sized first and give it a proper value. Otherwise
> mkfs.btrfs will complain something like
>
> "File system size 267386880 bytes is too small, 256M is required at least"
>
> This makes 015 077 and 083 run on btrfs.
But it's not really going to test the ENOSPC conditions it was designed
to exercise. It would be better to either find a way to make btrfs run on
smaller filesystem, or call _notrun for too small filesystems on btrfs
from _scratch_mkfs_sized.
>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> ---
> common.rc | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/common.rc b/common.rc
> index e948169..ab61786 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -356,6 +356,11 @@ _scratch_mkfs_sized()
> /sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
> ;;
> btrfs)
> + # btrfs needs at least 256M file system size
> + if [ $fssize -lt $((256*1024*1024)) ]
> + then
> + fssize=$((256*1024*1024))
> + fi
> $MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV
> ;;
> *)
> --
> 1.7.7.1
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-04 5:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 2:38 [PATCH 1/2] xfstests: 083 make variable filesize as size in bytes Eryu Guan
2011-11-04 2:38 ` [PATCH 2/2] xfstests: meet btrfs fs size requirement in _scratch_mkfs_sized() Eryu Guan
2011-11-04 5:39 ` Christoph Hellwig [this message]
2011-11-04 6:06 ` Eryu Guan
2011-11-04 8:21 ` Stefan Behrens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104053908.GB16720@infradead.org \
--to=hch@infradead.org \
--cc=guaneryu@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox