From: Christoph Hellwig <hch@infradead.org>
To: Jakub Bogusz <qboosh@pld-linux.org>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfsprogs: fix various incorrect printf formats
Date: Sat, 5 Nov 2011 05:33:17 -0400 [thread overview]
Message-ID: <20111105093317.GB5303@infradead.org> (raw)
In-Reply-To: <20111105090029.GA15258@stranger.qboosh.pl>
> > do_warn(
> > -_("inode 0x%" PRIu64 "bmap block 0x%" PRIu64 " claimed, state is %d\n"),
> > +_("inode 0x%" PRIu64 "bmap block 0x%" PRIx64 " claimed, state is %d\n"),
> > ino, bno, state);
> > break;
> > case XR_E_MULT:
> > case XR_E_INUSE_FS:
> > set_bmap(agno, agbno, XR_E_MULT);
> > do_warn(
> > -_("inode 0x%" PRIu64 " bmap block 0x%" PRIu64 " claimed, state is %d\n"),
> > +_("inode 0x%" PRIu64 " bmap block 0x%" PRIx64 " claimed, state is %d\n"),
> > ino, bno, state);
> > /*
> > * if we made it to here, this is probably a bmap block
>
> These two entries still need fix in the first format strings of both
> msgids...
>
> I'm attaching my version of the whole patch.
I've already put the previous version in. I'll commit the updates
attributed to you.
Sorry for the mess, and thanks a lot for looking over this.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-11-05 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 11:52 [PATCH] xfsprogs: fix various incorrect printf formats Christoph Hellwig
2011-10-25 15:59 ` Jakub Bogusz
2011-11-02 9:20 ` [PATCH v2] " Christoph Hellwig
2011-11-05 9:00 ` Jakub Bogusz
2011-11-05 9:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111105093317.GB5303@infradead.org \
--to=hch@infradead.org \
--cc=qboosh@pld-linux.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox