From: Carlos Maiolino <cmaiolino@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs_repair: Add inline function to get avl tree node
Date: Tue, 8 Nov 2011 17:02:12 -0200 [thread overview]
Message-ID: <20111108190212.GB21214@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <4EB97B53.7080600@sandeen.net>
On Tue, Nov 08, 2011 at 12:56:19PM -0600, Eric Sandeen wrote:
> On 11/8/11 12:46 PM, Carlos Maiolino wrote:
> > dd get_inode_offset() inline function, which will return the offset
> > of a specific node in the AVL tree avoiding the need to calculate the
> > the offset each time it needs to be used.
>
> might be good to find the open-coded instances of this, and
> make them use the helper too.
>
> -Eric
>
Yep, I can trck down these instances and replace by this function later
with no problem
--
--Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-08 19:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 18:46 [PATCH 0/2] Set lost+found inode as used after its allocation Carlos Maiolino
2011-11-08 18:46 ` [PATCH 1/2] xfs_repair: Add inline function to get avl tree node Carlos Maiolino
2011-11-08 18:56 ` Eric Sandeen
2011-11-08 19:02 ` Carlos Maiolino [this message]
2011-11-08 19:07 ` Christoph Hellwig
2011-11-08 18:46 ` [PATCH 2/2] xfs_repair: Properly set lost+found inode as used Carlos Maiolino
2011-11-08 18:55 ` Eric Sandeen
2011-11-08 19:07 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2011-11-09 16:54 [PATCH 0/2] Set lost+found inode as used after its allocation Carlos Maiolino
2011-11-09 16:54 ` [PATCH 1/2] xfs_repair: Add inline function to get avl tree node Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108190212.GB21214@andromeda.usersys.redhat.com \
--to=cmaiolino@redhat.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox