From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/8] xfsprogs: unconditionally drop used buffer reference
Date: Sun, 13 Nov 2011 06:59:40 -0500 [thread overview]
Message-ID: <20111113115940.GB19435@infradead.org> (raw)
In-Reply-To: <f4640a738a62150c745c843b92c5d143ad1cb155.1320955675.git.aelder@sgi.com>
On Thu, Nov 10, 2011 at 02:35:12PM -0600, Alex Elder wrote:
> In libxfs_mount(), after reading the last block in the log device,
> the buffer is released by a call to libxfs_putbuf(). But it's done
> only if bp is non-null. It always will be non-null at this point,
> so just make the call unconditionally.
>
> Also touch up a misleading indent.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
> ---
> libxfs/init.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/libxfs/init.c b/libxfs/init.c
> index 08fc584..ba44c9b 100644
> --- a/libxfs/init.c
> +++ b/libxfs/init.c
> @@ -743,15 +743,14 @@ libxfs_mount(
> if (!(flags & LIBXFS_MOUNT_DEBUGGER))
> return NULL;
> }
> - if (bp)
> - libxfs_putbuf(bp);
> + libxfs_putbuf(bp);
> }
This one isn't correct. If LIBXFS_MOUNT_DEBUGGER is set we still
get through to here.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-13 11:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 20:35 [PATCH 0/8] xfsprogs: new resvsp db command, plus some fixes Alex Elder
2011-11-10 20:35 ` [PATCH 1/8] xfsprogs: Fix setbitval() bug when nbits is byte-aligned Alex Elder
2011-11-10 20:35 ` [PATCH 2/8] xfsprogs: unconditionally drop used buffer reference Alex Elder
2011-11-13 11:59 ` Christoph Hellwig [this message]
2011-11-10 20:35 ` [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer Alex Elder
2011-11-13 12:01 ` Christoph Hellwig
2012-02-07 18:38 ` Christoph Hellwig
2012-02-07 20:25 ` Kevan Rehm
2012-02-07 21:46 ` Kevan Rehm
2011-11-10 20:35 ` [PATCH 4/8] xfsprogs: mkfs.xfs: let libxfs_umount() do its thing Alex Elder
2011-11-13 12:04 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 5/8] xfsprogs: Drop root inode refrerence in libxfs_umount() Alex Elder
2011-11-13 12:07 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 6/8] xfsprogs: xfs_db: unmount fs before exiting Alex Elder
2011-11-13 12:09 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 7/8] xfsprogs: clean up errors in libxfs_mount() consistently Alex Elder
2011-11-14 10:28 ` Christoph Hellwig
2011-11-10 20:35 ` [PATCH 8/8] xfsprogs: xfs_db: add new "resvsp" command Alex Elder
2011-11-11 1:29 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111113115940.GB19435@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox