From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pADC1Zn0110073 for ; Sun, 13 Nov 2011 06:01:36 -0600 Date: Sun, 13 Nov 2011 07:01:33 -0500 From: Christoph Hellwig Subject: Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer Message-ID: <20111113120133.GC19435@infradead.org> References: <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@sgi.com> <6833e89ecf7daa3ba69676fb98a4538ee6c3a1b5.1320955675.git.aelder@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6833e89ecf7daa3ba69676fb98a4538ee6c3a1b5.1320955675.git.aelder@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: Kevan Rehm , xfs@oss.sgi.com On Thu, Nov 10, 2011 at 02:35:13PM -0600, Alex Elder wrote: > From: Kevan Rehm > > In phase 6, in mk_root_dir(), xfs_repair initializes the mount > point's m_rootip pointer without accounting for that reference. > This field never really used or needed in repair otherwise, and the > assigned pointer doesn't really represent a real reference to an > inode that needs to be cached. So just kill off this assignment. > > Signed-off-by: Alex Elder Shouldn't this also have Kevan's signoff? > --- > repair/phase6.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/repair/phase6.c b/repair/phase6.c > index 1c82cb1..81d7fe6 100644 > --- a/repair/phase6.c > +++ b/repair/phase6.c > @@ -797,8 +797,6 @@ mk_root_dir(xfs_mount_t *mp) > ip->i_df.if_bytes = ip->i_df.if_real_bytes = 0; > ip->i_df.if_u1.if_extents = NULL; > > - mp->m_rootip = ip; > - Looks good, but can we extent this a bit? The only reference to mp->m_rootip in the userspace code is in libxfs_mount. By making it a local variable there we can kill the field entirely. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs