From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfsdump: handle Ctrl-D during prompts
Date: Mon, 14 Nov 2011 05:29:58 -0500 [thread overview]
Message-ID: <20111114102958.GC31043@infradead.org> (raw)
In-Reply-To: <1320951342-15477-1-git-send-email-wkendall@sgi.com>
On Thu, Nov 10, 2011 at 12:55:42PM -0600, Bill Kendall wrote:
> xfsdump does not currently handle Ctrl-D well during a dialog
> prompt. If some text is entered followed by Ctrl-D, an assert
> will trip because xfsdump expects a new-line character at the
> end of the user's input (or if asserts are disabled, the last
> character the user entered will be dropped).
>
> If Ctrl-D is entered without entering any response, some dialog
> callers (e.g., tree_subtree_inter()) will abort because they
> receive an unexpected response code.
>
> This patch changes xfsdump to behave like other interactive
> commands (xfs_db, bash, parted, ...) with respect to Ctrl-D.
> If Ctrl-D precedes any input, an empty string is returned.
> If Ctrl-D follows some input, it is ignored and xfsdump will
> continue to wait for more input.
>
> Signed-off-by: Bill Kendall <wkendall@sgi.com>
Looks good, I'll put this in during the next round of userspace updates.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-11-14 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 18:55 [PATCH v2] xfsdump: handle Ctrl-D during prompts Bill Kendall
2011-11-14 10:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114102958.GC31043@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox