From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] repair: validate acl count before reading it
Date: Wed, 16 Nov 2011 02:58:29 -0500 [thread overview]
Message-ID: <20111116075829.GA15620@infradead.org> (raw)
In-Reply-To: <20111116002323.GW5534@dastard>
On Wed, Nov 16, 2011 at 11:23:23AM +1100, Dave Chinner wrote:
> > count = be32_to_cpu(dacl->acl_cnt);
> > + if (count > XFS_ACL_MAX_ENTRIES) {
> > + do_warn(_("to larget ACL, size %d"), count);
>
> "Too many ACL entries, count %d\n"
Ok.
> > + *aclp = NULL;
> > + return EINVAL;
> > + }
> > +
> > +
> > end = &dacl->acl_entry[0] + count;
> > acl = malloc((int)((char *)end - (char *)dacl));
> > - if (!acl)
> > - return NULL;
> > + if (!acl) {
> > + do_warn(_("cannot malloc enough for ACL attribute\n"));
> > + do_warn(_("SKIPPING this ACL\n"));
>
> Should you put that same "Skipping" message for all the error cases?
For the ENOMEM case we indeed skip the ACL. For other errors we will
just remove this attribute. Given how enomem really should not just
happen for that small ACL I wonder how special casing it makes any
sense - but that code has been there for a while.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-16 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 8:07 [PATCH] repair: validate acl count before reading it Christoph Hellwig
2011-11-16 0:23 ` Dave Chinner
2011-11-16 7:58 ` Christoph Hellwig [this message]
2012-01-27 19:54 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111116075829.GA15620@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox