From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] repair: avoid ABBA deadlocks on prefetched buffers
Date: Thu, 17 Nov 2011 15:25:43 +1100 [thread overview]
Message-ID: <20111117042543.GF7046@dastard> (raw)
In-Reply-To: <20111115210953.GA6670@infradead.org>
On Tue, Nov 15, 2011 at 04:09:53PM -0500, Christoph Hellwig wrote:
> Both the prefetch threads and actual repair processing threads can have
> multiple buffers at a time locked, but they do no use a common locker
> order, which can lead to ABBA deadlocks while trying to lock the buffers.
>
> Switch the prefetch code to do a trylock and skip buffers that have
> already been locked to avoid this deadlock.
>
> Reported-by: Arkadiusz Mi??kiewicz <arekm@maven.pl>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks sane to me.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-17 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 21:09 [PATCH] repair: avoid ABBA deadlocks on prefetched buffers Christoph Hellwig
2011-11-17 4:25 ` Dave Chinner [this message]
2011-11-18 8:44 ` Arkadiusz Miśkiewicz
2011-11-22 22:46 ` Christoph Hellwig
2011-11-23 17:27 ` Arkadiusz Miśkiewicz
2012-01-13 20:09 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117042543.GF7046@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox