From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues
Date: Thu, 17 Nov 2011 02:25:43 -0500 [thread overview]
Message-ID: <20111117072543.GA3733@infradead.org> (raw)
In-Reply-To: <20111116232430.GB7046@dastard>
On Thu, Nov 17, 2011 at 10:24:30AM +1100, Dave Chinner wrote:
> Don't need the undef here anymore as the #define is in the header
> file and not local to the function.
I'll fix it up.
> Can't say I'm a great fan of this - making the workqueue code use
> kstrdup() would be a much better better solution, IMO, just like was
> done a while for the SLAB cache names to solve exactly the same
> problem....
Tejun has a patch to make the name argument to alloc_workqueue both
dynamically allocated and varags format. That'll fix it, but we can't
rely on it yet. I will switch over to it later in the 3.3 cycle.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-17 7:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 20:14 [PATCH 0/5] for-3.2 queue Christoph Hellwig
2011-11-15 20:14 ` [PATCH 1/5] [PATCH] xfs: fix attr2 vs large data fork assert Christoph Hellwig
2011-11-16 23:15 ` Dave Chinner
2011-11-17 7:30 ` Christoph Hellwig
2011-11-29 18:48 ` Ben Myers
2011-11-29 18:55 ` Christoph Hellwig
2011-11-19 17:44 ` [PATCH v2] " Christoph Hellwig
2011-11-15 20:14 ` [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-11-16 19:01 ` Ben Myers
2011-11-17 7:40 ` Christoph Hellwig
2011-11-16 23:24 ` Dave Chinner
2011-11-17 7:25 ` Christoph Hellwig [this message]
2011-11-15 20:14 ` [PATCH 3/5] xfs: do not require an ioend for new EOF calculation Christoph Hellwig
2011-11-16 18:09 ` Ben Myers
2011-11-16 23:28 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2011-11-08 8:56 [PATCH 0/5] log all file size updates Christoph Hellwig
2011-11-08 8:56 ` [PATCH 2/5] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-11-08 23:11 ` Dave Chinner
2011-11-09 7:58 ` Christoph Hellwig
2011-11-10 17:42 ` Ben Myers
2011-11-14 10:34 ` Christoph Hellwig
2011-11-14 18:13 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117072543.GA3733@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox