From: Dave Chinner <david@fromorbit.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] 198, 240: check presence of aiodio_sparce2
Date: Tue, 22 Nov 2011 20:33:16 +1100 [thread overview]
Message-ID: <20111122093316.GB8098@dastard> (raw)
In-Reply-To: <4ECB3DCA.5000509@jp.fujitsu.com>
On Tue, Nov 22, 2011 at 03:14:34PM +0900, Hidetoshi Seto wrote:
> Use same trick with:
> commit 4e9072472fbc56b9d4c8ee8094cc62ce793df9b7
> Gracefully fail aio tests if they weren't built
Good idea, but given this check is now repeated in multiple places,
wrapping it in a "_require_aiodio" helper function is probably in
order.
It might also be useful to define AIODIO_SPARSE and AIODIO_SPARSE2
variables (similar to, say, XFS_IO_PROG) so that it doesn't have to
be open coded in all the tests....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-22 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 6:14 [PATCH] 198, 240: check presence of aiodio_sparce2 Hidetoshi Seto
2011-11-22 9:33 ` Dave Chinner [this message]
2011-11-22 9:44 ` Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122093316.GB8098@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox