[PATCH] 198, 240: check presence of aiodio_sparce2

[PATCH] 198, 240: check presence of aiodio_sparce2

[Hidetoshi Seto]

Use same trick with:
  commit 4e9072472fbc56b9d4c8ee8094cc62ce793df9b7
  Gracefully fail aio tests if they weren't built

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
 198 |    5 ++++-
 240 |    5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/198 b/198
index e46ec8d..60db6dc 100755
--- a/198
+++ b/198
@@ -45,13 +45,16 @@ _cleanup()
 _supported_fs generic
 _supported_os Linux
 
+AIO_TEST=src/aio-dio-regress/aiodio_sparse2
+[ -x $here/$AIO_TEST ] || _notrun "$AIO_TEST not built"
+
 echo "Silence is golden."
 
 # real QA test starts here
 rm -f $seq.full
 
 rm -f "$TEST_DIR/aiodio_sparse*"
-$here/src/aio-dio-regress/aiodio_sparse2 "$TEST_DIR/aiodio_sparse"
+$here/$AIO_TEST "$TEST_DIR/aiodio_sparse"
 
 status=$?
 exit
diff --git a/240 b/240
index 563449e..22c1756 100755
--- a/240
+++ b/240
@@ -53,6 +53,9 @@ _supported_os Linux
 
 _require_sparse_files
 
+AIO_TEST=src/aio-dio-regress/aiodio_sparse2
+[ -x $here/$AIO_TEST ] || _notrun "$AIO_TEST not built"
+
 echo "Silence is golden."
 
 # real QA test starts here
@@ -69,7 +72,7 @@ fi
 
 # 2 threads, fs block sized writes, 64k filesize, stride through file by
 # fs block size, start at logical block size offset
-$here/src/aio-dio-regress/aiodio_sparse2 -i 2 -w $fs_block_size -s 64k -n $fs_block_size -o $logical_block_size "$TEST_DIR/aiodio_sparse"
+$here/$AIO_TEST -i 2 -w $fs_block_size -s 64k -n $fs_block_size -o $logical_block_size "$TEST_DIR/aiodio_sparse"
 
 status=$?
 exit
-- 
1.7.7.3


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] 198, 240: check presence of aiodio_sparce2

[Dave Chinner]

On Tue, Nov 22, 2011 at 03:14:34PM +0900, Hidetoshi Seto wrote:
> Use same trick with:
>   commit 4e9072472fbc56b9d4c8ee8094cc62ce793df9b7
>   Gracefully fail aio tests if they weren't built

Good idea, but given this check is now repeated in multiple places,
wrapping it in a "_require_aiodio" helper function is probably in
order.

It might also be useful to define AIODIO_SPARSE and AIODIO_SPARSE2
variables (similar to, say, XFS_IO_PROG) so that it doesn't have to
be open coded in all the tests....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] 198, 240: check presence of aiodio_sparce2

[Hidetoshi Seto]

(2011/11/22 18:33), Dave Chinner wrote:
> Good idea, but given this check is now repeated in multiple places,
> wrapping it in a "_require_aiodio" helper function is probably in
> order.

Good point.
OK, I'll make a patch to implement the "_require_aiodio" helper.

Thanks,
H.Seto

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs