From: Christoph Hellwig <hch@infradead.org>
To: Chandra Seetharaman <sekharan@us.ibm.com>
Cc: Christoph Hellwig <hch@infradead.org>,
XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: Remove the entries from the queue while waking them up.
Date: Tue, 22 Nov 2011 05:23:31 -0500 [thread overview]
Message-ID: <20111122102331.GA32485@infradead.org> (raw)
In-Reply-To: <1321902701.2201.141.camel@chandra-lucid.austin.ibm.com>
On Mon, Nov 21, 2011 at 01:11:41PM -0600, Chandra Seetharaman wrote:
> The code does not assume that it got the space when it wakes up. After
> every wake up it does check for free bytes available and compares to
> required bytes before granting the bytes to itself. (IOW, after waking
> up it behaves the same way as the lock-less case)
>
> As Dave pointed, I can see only the signal case to be effecting this
> scenario. With that case in mind, I can see one change required to my
> patch: Add the ticket to the list the second time (in a function) only
> if the t_queue is not empty.
You can still leak with the process added to the queue if you get a
wakeup and there is space available. And your second patch now has
to re-add conditional add to queue band aids that the first one so
nicely removed. My version of that patch has the big advantage of
actually making the whole scheme mirror that of a wait queue. In fact
we could use workqueues and the helpers for it later (except for the
waker side, which is special).
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-11-22 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 19:20 [PATCH] xfs: Remove the entries from the queue while waking them up Chandra Seetharaman
2011-11-19 1:14 ` Dave Chinner
2011-11-21 23:01 ` Chandra Seetharaman
2011-11-19 18:19 ` Christoph Hellwig
2011-11-20 8:22 ` Dave Chinner
2011-11-20 11:43 ` Christoph Hellwig
2011-11-20 19:49 ` [PATCH v2] xfs: fix and cleanup logspace waiter lists Christoph Hellwig
2011-11-21 19:11 ` [PATCH] xfs: Remove the entries from the queue while waking them up Chandra Seetharaman
2011-11-22 10:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122102331.GA32485@infradead.org \
--to=hch@infradead.org \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox