From: Christoph Hellwig <hch@infradead.org>
To: Guoquan Yang <ygq51@hotmail.com>
Cc: linux-xfs@oss.sgi.com, hank peng <pengxihan@gmail.com>
Subject: Re: xfs: validate inode numbers in file handles correctly
Date: Wed, 23 Nov 2011 09:30:45 -0500 [thread overview]
Message-ID: <20111123143045.GA20892@infradead.org> (raw)
In-Reply-To: <loom.20111123T134243-580@post.gmane.org>
On Wed, Nov 23, 2011 at 01:04:58PM +0000, Guoquan Yang wrote:
> I meet with a problem when using 64bit XFS and NFS,
>
> When I access a directory from the NFS client,I get Stale NFS file Handle
> error.But it is ok when accessing on the server without NFS.
>
> And I have checked that the inode num in the NFS file handle is the same as
> inode num on the server, Using ls -il.
>
> I found that XFS_IGET_UNTRUSTED in xfs_imap() filtered the function
> xfs_imap_lookup(),It fails in xfs_imap_lookup() when access from NFS
> client.local access does not go into xfs_imap_lookup().
>
> My kernel is Linux2.6.35.6 from kernel.org. please help me to find out this
> problem!
It seems like you hit the same issue hank peng reported recently, and
in facr your are on the same kernel for the serve as he is.
>From a closer look it seems like the changes you mentioned above indeed
had a bug in Linux 2.6.35, which was later fixed with the following
commit
mmit 4536f2ad8b330453d7ebec0746c4374eadd649b1
Author: Dave Chinner <dchinner@redhat.com>
Date: Tue Aug 24 11:42:30 2010 +1000
xfs: fix untrusted inode number lookup
which should be included in Linux 2.6.35.6. Can you make sure you
really have the commit? Can you also verify that a recent kernel
like Linux 3.0-stable shows the same behaviour?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-11-23 14:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 7:32 xfs: validate inode numbers in file handles correctly Dave Chinner
2010-06-18 7:32 ` [PATCH 1/4] xfs: always use iget in bulkstat Dave Chinner
2010-06-18 7:32 ` [PATCH 2/4] xfs: validate untrusted inode numbers during lookup Dave Chinner
2010-06-18 11:41 ` Christoph Hellwig
2010-06-19 0:07 ` Dave Chinner
2010-06-18 7:32 ` [PATCH 3/4] xfs: rename XFS_IGET_BULKSTAT to XFS_IGET_UNTRUSTED Dave Chinner
2010-06-18 11:42 ` Christoph Hellwig
2010-06-18 7:32 ` [PATCH 4/4] xfs: remove block number from inode lookup code Dave Chinner
2010-06-18 8:22 ` Christoph Hellwig
2011-11-23 13:04 ` xfs: validate inode numbers in file handles correctly Guoquan Yang
2011-11-23 14:30 ` Christoph Hellwig [this message]
[not found] ` <SNT135-W7F5C64C2A3F67B48EFF3AA4CE0@phx.gbl>
2011-11-24 12:52 ` Christoph Hellwig
2011-11-28 11:19 ` Christoph Hellwig
2011-12-03 8:27 ` hank peng
2011-12-06 15:17 ` Christoph Hellwig
2011-12-03 9:56 ` yangguoquan
2011-12-29 9:19 ` xfs: validate inode numbers in file handles correctly--NFS Stale File Handle Again yangguoquan
2012-01-02 15:02 ` Christoph Hellwig
2012-01-04 2:20 ` yangguoquan
2012-01-24 17:58 ` Christoph Hellwig
2012-02-01 5:46 ` yangguoquan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123143045.GA20892@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
--cc=pengxihan@gmail.com \
--cc=ygq51@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox