Re: [PATCH] libxfs: Get Physical Sector Size instead of Logical Sector size

Eric Sandeen
2011-11-29T17:38:35Z

On 11/29/11 11:15 AM, Martin K. Petersen wrote:
>>>>>> "Eric" == Eric Sandeen <sandeen@sandeen.net> writes:
>
> Eric> It seems that we should be checking for any alignment offsets in
> Eric> libxfs then, too; if there IS an offset, then perhaps 4k is the
> Eric> wrong answer, (perhaps there is no right answer) but if there is
> Eric> NO offset, 4k should be the right choice, yes?
>
> In most cases the partitioning/DM tools should give you a 0 offset. But
> it would a good idea to at least print a warning if lbs != pbs and
> offset > 0.

Right, Dave's concern was for when the partitioning tools didn't do the
job, we don't want to break fs consistency guarantees...

Dave, does checking for an offset before choosing 4k sectors seem
sufficient to you?

>
> Eric> And if the drive is broken then c'est la vie?
>
> Yes :)
>
>
> FWIW, the reason 4KB lbs drives are having a revival in the is that
> there is not a lot of confidence in 512e for the enterprise. Many
> vendors won't support them in servers due to correctness concerns and
> lack of performance predictability.

Imagine. :)

-Eric