From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfs: fix the logspace waiting algorithm
Date: Thu, 1 Dec 2011 02:21:49 -0500 [thread overview]
Message-ID: <20111201072149.GA1319@infradead.org> (raw)
In-Reply-To: <20111130235641.GX29840@sgi.com>
On Wed, Nov 30, 2011 at 05:56:41PM -0600, Ben Myers wrote:
> Christoph,
>
> I feel that the ordering of the accesses to l_grant_head and the writeq
> list may be important in the lockless path, and notice that they used to
> be in opposite order. It could use a comment explaining why (if) it is
> ok.
Do you mean moving the xlog_space_left after the first
list_empty_careful check in xlog_grant_log_space? It doesn't matter
given that we re-check the available space after each wakeup.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-01 7:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 8:17 [PATCH 0/4] xfs fixes for Linux 3.2-rc3 Christoph Hellwig
2011-11-28 8:17 ` [PATCH 1/4] xfs: fix attr2 vs large data fork assert Christoph Hellwig
2011-11-28 18:01 ` Ben Myers
2011-11-28 18:03 ` Christoph Hellwig
2011-11-28 8:17 ` [PATCH 2/4] xfs: validate acl count Christoph Hellwig
2011-11-28 8:17 ` [PATCH 3/4] xfs: force buffer writeback before blocking on the ilock in inode reclaim Christoph Hellwig
2011-11-28 8:17 ` [PATCH 4/4] xfs: fix the logspace waiting algorithm Christoph Hellwig
2011-11-30 23:56 ` Ben Myers
2011-12-01 7:21 ` Christoph Hellwig [this message]
2011-12-01 19:51 ` Ben Myers
2011-12-02 11:51 ` Christoph Hellwig
2011-12-05 2:53 ` Dave Chinner
2011-12-05 9:05 ` Christoph Hellwig
2011-12-01 18:32 ` Ben Myers
2011-12-01 20:43 ` Chandra Seetharaman
2011-12-01 19:28 ` Chandra Seetharaman
2011-12-02 11:16 ` Christoph Hellwig
2011-12-02 16:02 ` Chandra Seetharaman
2011-11-29 19:23 ` [PATCH 0/4] xfs fixes for Linux 3.2-rc3 Ben Myers
2011-11-30 8:54 ` Christoph Hellwig
2011-11-30 8:58 ` [PATCH 5/4] xfs: fix nfs export of 64-bit inodes numbers on 32-bit kernels Christoph Hellwig
2011-12-02 16:07 ` Ben Myers
2011-12-02 17:29 ` Christoph Hellwig
2011-12-06 16:39 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201072149.GA1319@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox