Re: [PATCH 02/16] xfs: make sure to really flush all dquots in xfs_qm_quotacheck

Dave Chinner
2011-12-05T04:01:24Z

On Mon, Nov 28, 2011 at 03:27:24AM -0500, Christoph Hellwig wrote:
> Make sure we do not skip any dquots when flushing them out after a
> quotacheck to make sure that we will never have any dirty dquots on a life
live
> filesystem. At this point no dquot should be pinnable, but lets be anal
pedantic
> about it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> ---
> fs/xfs/xfs_qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: xfs/fs/xfs/xfs_qm.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_qm.c 2011-11-25 11:45:32.672075575 +0100
> +++ xfs/fs/xfs/xfs_qm.c 2011-11-25 11:45:35.875391556 +0100
> @@ -1661,7 +1661,7 @@ xfs_qm_quotacheck(
> * successfully.
> */
> if (!error)
> - error = xfs_qm_dqflush_all(mp, SYNC_TRYLOCK);
> + error = xfs_qm_dqflush_all(mp, 0);
>
> /*
> * We can get this error if we couldn't do a dquot allocation inside

We definitely should flush everything here, so looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com