Re: [PATCH 09/16] xfs: flatten the dquot lock ordering

Dave Chinner
2011-12-05T09:35:03Z

On Mon, Dec 05, 2011 at 04:11:21AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 05, 2011 at 04:04:28PM +1100, Dave Chinner wrote:
> > > @@ -509,46 +518,27 @@ xfs_qm_dqpurge_int(
> > > */
> > > xfs_qm_detach_gdquots(mp);
> > >
> > > - again:
> > > - nmisses = 0;
> >
> > I don't think that nmisses is initialised to zero correctly anymore.
>
> We do a
>
> int nmisses = 0;
>
> at the top of the function. Now that there are no retry loops that's
> sufficient.

Hmmmm. My unmodified tree just has the declaration without
initialisation, and I didn't find any place where the initialisation
was added in the preceding patches. I'll go back and have another
look.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com