Re: [PATCH 07/16] xfs: remove XFS_DQ_INACTIVE

Christoph Hellwig
2011-12-05T08:37:44Z

On Mon, Dec 05, 2011 at 03:23:51PM +1100, Dave Chinner wrote:
> > + xfs_qm_dqdestroy(dqp);
> > return (0);
> > }
>
> While there, you may as well make that a "return 0;"

Indeed.

> > - mutex_unlock(&xqm->qm_dqfrlist_lock);
> > - mutex_destroy(&xqm->qm_dqfrlist_lock);
> > kmem_free(xqm);
> > }
>
> Don't we still need that mutex_destroy() call there?

We never needed it - Linux does an implicit mutex_destory when freeing
memory containing a mutex.