From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfs: cleanup the transaction commit path a bit
Date: Mon, 5 Dec 2011 03:35:34 -0500 [thread overview]
Message-ID: <20111205083534.GA29401@infradead.org> (raw)
In-Reply-To: <20111205035516.GF7046@dastard>
On Mon, Dec 05, 2011 at 02:55:16PM +1100, Dave Chinner wrote:
> > + *
> > + * Note that this format differs from the old log vector format in that there
> > + * is no transaction header in these log vectors.
>
> Do we even need this comment given the old itransaction commit code
> that did this is now gone?
We could probably drop this, yes.
> Would it make sense to have IOP_FORMAT return the length of the
> vectors (calculated as itis built) rather than having to add them up
> after the fact? That would avoid an extra pass across the vector
> array. Regardless, it can be done as a future patch...
I have a WIP patch for that, but it's not quite ready yet.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-05 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 8:25 [PATCH 0/3] remove the deprecated nodelaylog options Christoph Hellwig
2011-11-28 8:25 ` [PATCH 1/3] xfs: remove the deprecated nodelaylog option Christoph Hellwig
2011-12-05 3:39 ` Dave Chinner
2011-11-28 8:25 ` [PATCH 2/3] xfs: cleanup the transaction commit path a bit Christoph Hellwig
2011-12-05 3:55 ` Dave Chinner
2011-12-05 8:35 ` Christoph Hellwig [this message]
2011-11-28 8:25 ` [PATCH 3/3] xfs: remove the lid_size field in struct log_item_desc Christoph Hellwig
2011-12-05 3:56 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205083534.GA29401@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox