public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Peng Haitao <penght@cn.fujitsu.com>
Cc: hch@infradead.org, linux-xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument
Date: Tue, 6 Dec 2011 22:05:33 +1100	[thread overview]
Message-ID: <20111206110533.GD28326@dastard> (raw)
In-Reply-To: <4EDD8F16.4050402@cn.fujitsu.com>

On Tue, Dec 06, 2011 at 11:42:14AM +0800, Peng Haitao wrote:
> 
> When offset + length is overflow of xfs_io builtin pread and pwrite in linux,
> the error message should be "Invalid argument".

Fixing this just requires an additional filter. The write outpu is
already passed through 2 filters to remove ariable numbers from the
output, so one more to standardise the error isn't a problem.

Further, filtering of the error stream on the reads to only appear
in $seq.full solves the extra error output on reads as well.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-12-06 11:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-06  3:42 [PATCH] xfstests/071 FAIL with pwrite64: Invalid argument Peng Haitao
2011-12-06 11:05 ` Dave Chinner [this message]
2011-12-06 11:23   ` Christoph Hellwig
2011-12-07  8:17   ` Peng Haitao
2011-12-07 10:07     ` Dave Chinner
2011-12-08  2:25       ` Peng Haitao
2012-01-04 16:53         ` Christoph Hellwig
2012-01-06  3:53           ` Peng Haitao
2012-03-15  2:25           ` [PATCH v2] " Peng Haitao
2012-03-31 20:13             ` [PATCH v2] 071: make this test work as expected on Linux Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111206110533.GD28326@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-xfs@oss.sgi.com \
    --cc=penght@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox