From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 07/16] xfs: remove XFS_DQ_INACTIVE
Date: Tue, 6 Dec 2011 09:43:50 -0500 [thread overview]
Message-ID: <20111206144350.GA16767@infradead.org> (raw)
In-Reply-To: <20111205083741.GB29401@infradead.org>
On Mon, Dec 05, 2011 at 03:37:41AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 05, 2011 at 03:23:51PM +1100, Dave Chinner wrote:
> > > + xfs_qm_dqdestroy(dqp);
> > > return (0);
> > > }
> >
> > While there, you may as well make that a "return 0;"
>
> Indeed.
>
> > > - mutex_unlock(&xqm->qm_dqfrlist_lock);
> > > - mutex_destroy(&xqm->qm_dqfrlist_lock);
> > > kmem_free(xqm);
> > > }
> >
> > Don't we still need that mutex_destroy() call there?
>
> We never needed it - Linux does an implicit mutex_destory when freeing
> memory containing a mutex.
Does this count as a revied-by now?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-06 14:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 8:27 [PATCH 00/16] quota cleanups for Linux 3.3 Christoph Hellwig
2011-11-28 8:27 ` [PATCH 01/16] xfs: untange SYNC_WAIT and SYNC_TRYLOCK meanings for xfs_qm_dqflush Christoph Hellwig
2011-12-05 3:57 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 02/16] xfs: make sure to really flush all dquots in xfs_qm_quotacheck Christoph Hellwig
2011-12-05 3:59 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 03/16] xfs: remove xfs_qm_sync Christoph Hellwig
2011-12-05 4:09 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 04/16] xfs: remove the sync_mode argument to xfs_qm_dqflush_all Christoph Hellwig
2011-12-05 4:09 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 05/16] xfs: cleanup dquot locking helpers Christoph Hellwig
2011-12-05 4:12 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 06/16] xfs: cleanup xfs_qm_dqlookup Christoph Hellwig
2011-12-05 4:17 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 07/16] xfs: remove XFS_DQ_INACTIVE Christoph Hellwig
2011-12-05 4:23 ` Dave Chinner
2011-12-05 8:37 ` Christoph Hellwig
2011-12-06 14:43 ` Christoph Hellwig [this message]
2011-12-06 20:34 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 08/16] xfs: implement lazy removal for the dquot freelist Christoph Hellwig
2011-12-05 4:32 ` Dave Chinner
2011-12-05 8:38 ` Christoph Hellwig
2011-11-28 8:27 ` [PATCH 09/16] xfs: flatten the dquot lock ordering Christoph Hellwig
2011-12-05 5:04 ` Dave Chinner
2011-12-05 9:11 ` Christoph Hellwig
2011-12-05 9:34 ` Dave Chinner
2011-12-05 11:50 ` Christoph Hellwig
2011-12-06 0:25 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 10/16] xfs: nest qm_dqfrlist_lock insise the dquot qlock Christoph Hellwig
2011-12-05 5:10 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 11/16] xfs: simplify xfs_qm_dqattach_grouphint Christoph Hellwig
2011-12-05 5:14 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 12/16] xfs: simplify xfs_qm_detach_gdquots Christoph Hellwig
2011-12-05 5:18 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 13/16] xfs: add a xfs_dqhold helper Christoph Hellwig
2011-12-05 5:22 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 14/16] xfs: merge xfs_qm_dqinit_core into the only caller Christoph Hellwig
2011-12-05 5:23 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 15/16] xfs: kill xfs_qm_idtodq Christoph Hellwig
2011-12-05 5:31 ` Dave Chinner
2011-11-28 8:27 ` [PATCH 16/16] xfs: remove XFS_QMOPT_DQSUSER Christoph Hellwig
2011-12-05 5:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206144350.GA16767@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox