From: Christoph Hellwig <hch@infradead.org>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: check if qa user can execute commands
Date: Tue, 6 Dec 2011 10:13:00 -0500 [thread overview]
Message-ID: <20111206151300.GA11874@infradead.org> (raw)
In-Reply-To: <1323165389-5419-1-git-send-email-list.btrfs@jan-o-sch.net>
On Tue, Dec 06, 2011 at 10:56:29AM +0100, Jan Schmidt wrote:
> _require_user only checks if the qa user exists in /etc/passwd. It may exist
> though still not be able to execute anything (e.g. with a /bin/false shell).
>
> _user_do cannot determine failure to execute the given command, as it uses
> _user_do_filter for post-processing which succeeds even if the command
> fails. Thus, the check should be performed by _require_user.
Looks good. Wouldn't
su $qa_user -c /bin/true
be the more normal way to write that test?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-06 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 9:56 [PATCH] xfstests: check if qa user can execute commands Jan Schmidt
2011-12-06 15:13 ` Christoph Hellwig [this message]
2011-12-06 15:16 ` Jan Schmidt
2011-12-06 15:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206151300.GA11874@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox