From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pB8GEZ5Z151593 for ; Thu, 8 Dec 2011 10:14:35 -0600 Date: Thu, 8 Dec 2011 10:14:57 -0600 From: Ben Myers Subject: Re: [patch 01/19] xfs: remove the deprecated nodelaylog option Message-ID: <20111208161457.GK749@sgi.com> References: <20111206215806.844405397@bombadil.infradead.org> <20111206215852.699758135@bombadil.infradead.org> <20111207214453.GR29840@sgi.com> <20111208161210.GA6326@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111208161210.GA6326@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Thu, Dec 08, 2011 at 11:12:10AM -0500, Christoph Hellwig wrote: > On Wed, Dec 07, 2011 at 03:44:53PM -0600, Ben Myers wrote: > > > - log->l_cilp = NULL; > > > - if (!(log->l_mp->m_flags & XFS_MOUNT_DELAYLOG)) > > > - return 0; > > > - > > > > There is a section of comment above xlog_cil_init that only applies if > > we could still switch the CIL off. It should be removed with this > > patch. > > Indeed. If there's enough comments that I need to respin the series > I'll remove it. If not please just remove it for while commiting the > patch. Good. I'll remove the comment. -Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs