From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pBDK2hDB170565 for ; Tue, 13 Dec 2011 14:02:44 -0600 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 009EF1D3A916 for ; Tue, 13 Dec 2011 11:45:00 -0800 (PST) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id KltUEuOaJZ70aGZy for ; Tue, 13 Dec 2011 11:45:00 -0800 (PST) Date: Wed, 14 Dec 2011 06:44:57 +1100 From: Dave Chinner Subject: Re: [patch 12/19] xfs: flatten the dquot lock ordering Message-ID: <20111213194457.GD14273@dastard> References: <20111206215806.844405397@bombadil.infradead.org> <20111206215854.769664827@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111206215854.769664827@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Tue, Dec 06, 2011 at 04:58:18PM -0500, Christoph Hellwig wrote: > Introduce a new XFS_DQ_FREEING flag that tells lookup and mplist walks > to skip a dquot that is beeing freed, and use this avoid the trylock > on the hash and mplist locks in xfs_qm_dqreclaim_one. Also simplify > xfs_dqpurge by moving the inodes to a dispose list after marking them > XFS_DQ_FREEING and avoid the locker ordering constraints. > > Signed-off-by: Christoph Hellwig Looks good to me withthe coment updates. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs