From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller
Date: Thu, 15 Dec 2011 11:00:21 -0600 [thread overview]
Message-ID: <20111215170021.GK29840@sgi.com> (raw)
In-Reply-To: <20111206215855.635965028@bombadil.infradead.org>
On Tue, Dec 06, 2011 at 04:58:23PM -0500, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>
> ---
> fs/xfs/xfs_dquot.c | 27 +++++++--------------------
> 1 file changed, 7 insertions(+), 20 deletions(-)
>
> Index: xfs/fs/xfs/xfs_dquot.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_dquot.c 2011-11-25 11:56:36.905143783 +0100
> +++ xfs/fs/xfs/xfs_dquot.c 2011-11-25 11:56:40.861789014 +0100
> @@ -154,24 +154,6 @@ xfs_qm_dqdestroy(
> }
>
> /*
> - * This is what a 'fresh' dquot inside a dquot chunk looks like on disk.
> - */
> -STATIC void
> -xfs_qm_dqinit_core(
> - xfs_dqid_t id,
> - uint type,
> - xfs_dqblk_t *d)
> -{
> - /*
> - * Caller has zero'd the entire dquot 'chunk' already.
> - */
> - d->dd_diskdq.d_magic = cpu_to_be16(XFS_DQUOT_MAGIC);
> - d->dd_diskdq.d_version = XFS_DQUOT_VERSION;
> - d->dd_diskdq.d_id = cpu_to_be32(id);
> - d->dd_diskdq.d_flags = type;
> -}
> -
> -/*
> * If default limits are in force, push them into the dquot now.
> * We overwrite the dquot limits only if they are zero and this
> * is not the root dquot.
> @@ -327,8 +309,13 @@ xfs_qm_init_dquot_blk(
> curid = id - (id % q->qi_dqperchunk);
> ASSERT(curid >= 0);
> memset(d, 0, BBTOB(q->qi_dqchunklen));
> - for (i = 0; i < q->qi_dqperchunk; i++, d++, curid++)
> - xfs_qm_dqinit_core(curid, type, d);
> + for (i = 0; i < q->qi_dqperchunk; i++, d++, curid++) {
> + d->dd_diskdq.d_magic = cpu_to_be16(XFS_DQUOT_MAGIC);
> + d->dd_diskdq.d_version = XFS_DQUOT_VERSION;
> + d->dd_diskdq.d_id = cpu_to_be32(curid);
> + d->dd_diskdq.d_flags = type;
> + }
> +
> xfs_trans_dquot_buf(tp, bp,
> (type & XFS_DQ_USER ? XFS_BLF_UDQUOT_BUF :
> ((type & XFS_DQ_PROJ) ? XFS_BLF_PDQUOT_BUF :
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-15 16:59 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 21:58 [patch 00/19] Linux 3.3 patchqueue Christoph Hellwig
2011-12-06 21:58 ` [patch 01/19] xfs: remove the deprecated nodelaylog option Christoph Hellwig
2011-12-07 21:44 ` Ben Myers
2011-12-08 16:12 ` Christoph Hellwig
2011-12-08 16:14 ` Ben Myers
2011-12-06 21:58 ` [patch 02/19] xfs: cleanup the transaction commit path a bit Christoph Hellwig
2011-12-08 17:44 ` Ben Myers
2011-12-06 21:58 ` [patch 03/19] xfs: remove the lid_size field in struct log_item_desc Christoph Hellwig
2011-12-08 18:35 ` Ben Myers
2011-12-06 21:58 ` [patch 04/19] xfs: untange SYNC_WAIT and SYNC_TRYLOCK meanings for xfs_qm_dqflush Christoph Hellwig
2011-12-08 21:10 ` Ben Myers
2011-12-06 21:58 ` [patch 05/19] xfs: make sure to really flush all dquots in xfs_qm_quotacheck Christoph Hellwig
2011-12-08 21:36 ` Ben Myers
2011-12-06 21:58 ` [patch 06/19] xfs: remove xfs_qm_sync Christoph Hellwig
2011-12-12 18:25 ` Ben Myers
2011-12-06 21:58 ` [patch 07/19] xfs: remove the sync_mode argument to xfs_qm_dqflush_all Christoph Hellwig
2011-12-12 22:33 ` Ben Myers
2011-12-06 21:58 ` [patch 08/19] xfs: cleanup dquot locking helpers Christoph Hellwig
2011-12-12 23:12 ` Ben Myers
2011-12-06 21:58 ` [patch 09/19] xfs: cleanup xfs_qm_dqlookup Christoph Hellwig
2011-12-13 17:30 ` Ben Myers
2011-12-06 21:58 ` [patch 10/19] xfs: remove XFS_DQ_INACTIVE Christoph Hellwig
2011-12-13 20:26 ` Ben Myers
2011-12-06 21:58 ` [patch 11/19] xfs: implement lazy removal for the dquot freelist Christoph Hellwig
2011-12-14 22:13 ` Ben Myers
2011-12-06 21:58 ` [patch 12/19] xfs: flatten the dquot lock ordering Christoph Hellwig
2011-12-13 19:44 ` Dave Chinner
2011-12-14 22:18 ` Ben Myers
2011-12-15 3:13 ` Ben Myers
2011-12-06 21:58 ` [patch 13/19] xfs: nest qm_dqfrlist_lock inside the dquot qlock Christoph Hellwig
2011-12-15 3:02 ` Ben Myers
2011-12-06 21:58 ` [patch 14/19] xfs: simplify xfs_qm_dqattach_grouphint Christoph Hellwig
2011-12-15 4:55 ` Ben Myers
2011-12-06 21:58 ` [patch 15/19] xfs: simplify xfs_qm_detach_gdquots Christoph Hellwig
2011-12-15 16:43 ` Ben Myers
2011-12-16 0:48 ` Dave Chinner
2011-12-16 21:33 ` Ben Myers
2011-12-06 21:58 ` [patch 16/19] xfs: add a xfs_dqhold helper Christoph Hellwig
2011-12-15 16:56 ` Ben Myers
2011-12-06 21:58 ` [patch 17/19] xfs: merge xfs_qm_dqinit_core into the only caller Christoph Hellwig
2011-12-15 17:00 ` Ben Myers [this message]
2011-12-06 21:58 ` [patch 18/19] xfs: kill xfs_qm_idtodq Christoph Hellwig
2011-12-15 20:07 ` Ben Myers
2011-12-06 21:58 ` [patch 19/19] xfs: remove XFS_QMOPT_DQSUSER Christoph Hellwig
2011-12-15 20:22 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215170021.GK29840@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox