From: Ben Myers <bpm@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: remove unused XBT_FORCE_SLEEP bit
Date: Thu, 15 Dec 2011 17:06:05 -0600 [thread overview]
Message-ID: <20111215230605.GN29840@sgi.com> (raw)
In-Reply-To: <4EE7DBED.8090600@sandeen.net>
On Tue, Dec 13, 2011 at 05:12:45PM -0600, Eric Sandeen wrote:
> XBT_FORCE_SLEEP is no longer ever tested; it is only set
> and cleared. Remove it.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Yep... looks like XBT_FORCE_SLEEP is never tested.
Reviewed-by: Ben Myers <bpm@sgi.com>
> ---
>
> p.s. I left bt_flags as a bitfield even with only one bit defined now... OK?
>
> diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c
> index 5e68099..f7830c3 100644
> --- a/fs/xfs/linux-2.6/xfs_buf.c
> +++ b/fs/xfs/linux-2.6/xfs_buf.c
> @@ -1762,12 +1762,8 @@ xfsbufd(
> struct list_head tmp;
> struct blk_plug plug;
>
> - if (unlikely(freezing(current))) {
> - set_bit(XBT_FORCE_SLEEP, &target->bt_flags);
> + if (unlikely(freezing(current)))
> refrigerator();
> - } else {
> - clear_bit(XBT_FORCE_SLEEP, &target->bt_flags);
> - }
>
> /* sleep for a long time if there is nothing to do. */
> if (list_empty(&target->bt_delwrite_queue))
> diff --git a/fs/xfs/linux-2.6/xfs_buf.h b/fs/xfs/linux-2.6/xfs_buf.h
> index 50a7d5f..1b4aec1 100644
> --- a/fs/xfs/linux-2.6/xfs_buf.h
> +++ b/fs/xfs/linux-2.6/xfs_buf.h
> @@ -87,8 +87,7 @@ typedef unsigned int xfs_buf_flags_t;
> { _XBF_DELWRI_Q, "DELWRI_Q" }
>
> typedef enum {
> - XBT_FORCE_SLEEP = 0,
> - XBT_FORCE_FLUSH = 1,
> + XBT_FORCE_FLUSH = 0,
> } xfs_buftarg_flags_t;
>
> typedef struct xfs_bufhash {
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-12-15 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 23:12 [PATCH] xfs: remove unused XBT_FORCE_SLEEP bit Eric Sandeen
2011-12-14 0:56 ` Dave Chinner
2011-12-15 23:06 ` Ben Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215230605.GN29840@sgi.com \
--to=bpm@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox