Re: [patch 01/19] xfs: remove the deprecated nodelaylog option

Ben Myers
2011-12-07T21:44:32Z

On Tue, Dec 06, 2011 at 04:58:07PM -0500, Christoph Hellwig wrote:
> The delaylog mode has been the default for a long time, and the nodelaylog
> option has been scheduled for removal in Linux 3.3. Remove it and code
> only used by it now that we have opened the 3.3 window.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Looks good, one comment below.
Reviewed-by: Ben Myers <bpm@sgi.com>

> Index: xfs/fs/xfs/xfs_log_cil.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_log_cil.c 2011-11-28 09:13:10.684813018 +0100
> +++ xfs/fs/xfs/xfs_log_cil.c 2011-11-28 09:17:38.320029780 +0100
> @@ -44,10 +44,6 @@ xlog_cil_init(

> struct xfs_cil *cil;
> struct xfs_cil_ctx *ctx;
>
> - log->l_cilp = NULL;
> - if (!(log->l_mp->m_flags & XFS_MOUNT_DELAYLOG))
> - return 0;
> -

There is a section of comment above xlog_cil_init that only applies if
we could still switch the CIL off. It should be removed with this
patch.