Re: [patch 03/19] xfs: remove the lid_size field in struct log_item_desc

Ben Myers
2011-12-08T18:35:24Z

On Tue, Dec 06, 2011 at 04:58:09PM -0500, Christoph Hellwig wrote:
> Outside the now removed nodelaylog code this field is only used for
> asserts and can be safely removed now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Looks good.
Reviewed-by: Ben Myers <bpm@sgi.com>

> Index: xfs/fs/xfs/xfs_inode_item.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_inode_item.c 2011-12-06 15:26:35.150334172 +0100
> +++ xfs/fs/xfs/xfs_inode_item.c 2011-12-06 15:36:07.963678127 +0100
> @@ -437,7 +437,6 @@ xfs_inode_item_format(
> * Assert that no attribute-related log flags are set.
> */
> if (!XFS_IFORK_Q(ip)) {
> - ASSERT(nvecs == lip->li_desc->lid_size);
> iip->ili_format.ilf_size = nvecs;
> ASSERT(!(iip->ili_format.ilf_fields &
> (XFS_ILOG_ADATA | XFS_ILOG_ABROOT | XFS_ILOG_AEXT)));
> @@ -521,7 +520,6 @@ xfs_inode_item_format(
> break;
> }
>
> - ASSERT(nvecs == lip->li_desc->lid_size);

These two look like they might have been useful.