From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pBHNEKAC132354 for ; Sat, 17 Dec 2011 17:14:21 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id Zqs3bs3oFeMnuvX2 for ; Sat, 17 Dec 2011 15:14:19 -0800 (PST) Date: Sat, 17 Dec 2011 18:14:19 -0500 From: Christoph Hellwig Subject: Re: [PATCH 04/12] xfs: add compound buffer get and read interfaces Message-ID: <20111217231418.GB2383@infradead.org> References: <1323238703-13198-1-git-send-email-david@fromorbit.com> <1323238703-13198-5-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1323238703-13198-5-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com After looking over all the patches I really thing we should be passing struct xfs_buf_vec arguments to the functions, and provide a helper to convert struct xfs_bmbt_irec to the callers. That avoids having to add the XFS_EXT_DADDR hack, and keeps the amount of data structures used in the buffer cache small. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs