From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC, PATCH 0/12] xfs: compound buffers for directory blocks
Date: Mon, 19 Dec 2011 10:01:03 +1100 [thread overview]
Message-ID: <20111218230103.GI23662@dastard> (raw)
In-Reply-To: <20111214183314.GA18724@infradead.org>
On Wed, Dec 14, 2011 at 01:33:14PM -0500, Christoph Hellwig wrote:
> I've been really busy the last days and only managed to look over this
> a bit while waiting for compiles and benchmarks.
>
> The only really major comment I have is that I start to really dislike
> the way struct xfs_bmbt_irec is used in the compound buffers. The
> XFS_EXT_DADDR flag basically gives the data types in there a totally
> different meaning and is really confusing for anyone reading the code:
> either we're using a "normal" one passes in from the directory code,
> or an artificial one used internally, which uses different units.
>
> I suspect we'd really be much better off introducing a new, smaller type
> here, especially as it's only seen inside the buffer code:
>
> struct xfs_buf_map {
> sector_t bm_bno;
> size_t bm_len;
> };
>
> any use it consistently, that is also use it to replace
> b_file_offset/b_buffer_length and b_bn. This will also make my number
> two suggestion a lot cleaner, that is make sure the new abstraction can
> be implemented for reading/writing log buffers that wrap around, and
> allow to kill off xfs_buf_associate_memory entirely.
Yeah, I was a bit unsure of the best way to do this. I started with
the bmbt_irec code because it already existed and was easy to pass
in from the directory code. It wasn't until I realised the sector
addressing issue later on that the XFS_EXT_DADDR came about. That
was a simple way of making it work, rather than rewriting the
patches again...
Ok, I'll go back and rewrite them to use a xfs_buf_map/vec and try
to address all your other points as well. Stay tuned.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-12-18 23:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 6:18 [RFC, PATCH 0/12] xfs: compound buffers for directory blocks Dave Chinner
2011-12-07 6:18 ` [PATCH 01/12] xfs: remove remaining scraps of struct xfs_iomap Dave Chinner
2011-12-08 16:02 ` Christoph Hellwig
2011-12-07 6:18 ` [PATCH 02/12] xfs: clean up buffer get/read call API Dave Chinner
2011-12-08 16:07 ` Christoph Hellwig
2011-12-07 6:18 ` [PATCH 03/12] xfs: introduce a compound buffer construct Dave Chinner
2011-12-17 23:11 ` Christoph Hellwig
2011-12-07 6:18 ` [PATCH 04/12] xfs: add compound buffer get and read interfaces Dave Chinner
2011-12-17 23:14 ` Christoph Hellwig
2011-12-07 6:18 ` [PATCH 05/12] xfs: add irec interfaces to xfs_trans_buf_get/read Dave Chinner
2011-12-07 6:18 ` [PATCH 06/12] xfs: convert xfs_da_do_buf to use irec buffer interface Dave Chinner
2011-12-07 6:18 ` [PATCH 07/12] xfs: switch the buffer get/read API to use irec methods Dave Chinner
2011-12-07 6:18 ` [PATCH 08/12] xfs: support multiple irec maps in buffer code Dave Chinner
2011-12-07 6:18 ` [PATCH 09/12] xfs: support compund buffers in buf_item logging Dave Chinner
2011-12-07 6:18 ` [PATCH 10/12] xfs: use multiple irec xfs buf support in dabuf Dave Chinner
2011-12-07 6:18 ` [PATCH 11/12] xfs: remove struct xfs_dabuf and infrastructure Dave Chinner
2011-12-17 23:30 ` Christoph Hellwig
2011-12-07 6:18 ` [PATCH 12/12] xfs: remove duplication in transaction buffer operations Dave Chinner
2011-12-17 23:32 ` Christoph Hellwig
2011-12-07 6:35 ` [RFC, PATCH 0/12] xfs: compound buffers for directory blocks Christoph Hellwig
2011-12-07 9:23 ` Dave Chinner
2011-12-14 18:33 ` Christoph Hellwig
2011-12-18 23:01 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111218230103.GI23662@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox