From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: mark the xfssyncd workqueue as non-reentrant
Date: Mon, 19 Dec 2011 11:02:27 +1100 [thread overview]
Message-ID: <20111219000227.GJ23662@dastard> (raw)
In-Reply-To: <20111205085321.GA10986@infradead.org>
On Mon, Dec 05, 2011 at 03:53:21AM -0500, Christoph Hellwig wrote:
> On a system with lots of memory pressure that is stuck on synchronous inode
> reclaim the workqueue code will run one instance of the inode reclaim work
> item on every CPU. which is not what we want. Make sure to mark the
> xfssyncd workqueue as non-reentrant to make sure there only is one instace
> of each running globally. Also stop using special paramater for the
> workqueue; now that we guarantee each fs has only running one of each works
> at a time there is no need to artificially lower max_active and compensate
> for that by setting the WQ_CPU_INTENSIVE flag.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Ok, I've had a look in detail at what the WQ_NON_REENTRANT flag does
and I agree that this is the correct behaviour for the xfssyncd -
only one instance per filesystem should run at any given time.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-19 0:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 8:53 [PATCH] xfs: mark the xfssyncd workqueue as non-reentrant Christoph Hellwig
2011-12-19 0:02 ` Dave Chinner [this message]
2011-12-20 16:45 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219000227.GJ23662@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox