From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pBJ02WIS002455 for ; Sun, 18 Dec 2011 18:02:32 -0600 Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id o7ajGQZ4ug5KijBY for ; Sun, 18 Dec 2011 16:02:29 -0800 (PST) Date: Mon, 19 Dec 2011 11:02:27 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs: mark the xfssyncd workqueue as non-reentrant Message-ID: <20111219000227.GJ23662@dastard> References: <20111205085321.GA10986@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111205085321.GA10986@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Dec 05, 2011 at 03:53:21AM -0500, Christoph Hellwig wrote: > On a system with lots of memory pressure that is stuck on synchronous inode > reclaim the workqueue code will run one instance of the inode reclaim work > item on every CPU. which is not what we want. Make sure to mark the > xfssyncd workqueue as non-reentrant to make sure there only is one instace > of each running globally. Also stop using special paramater for the > workqueue; now that we guarantee each fs has only running one of each works > at a time there is no need to artificially lower max_active and compensate > for that by setting the WQ_CPU_INTENSIVE flag. > > Signed-off-by: Christoph Hellwig Ok, I've had a look in detail at what the WQ_NON_REENTRANT flag does and I agree that this is the correct behaviour for the xfssyncd - only one instance per filesystem should run at any given time. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs