From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pBLGBdT4033240 for ; Wed, 21 Dec 2011 10:11:39 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id k01yOyey5i8RbA2V for ; Wed, 21 Dec 2011 08:11:38 -0800 (PST) Date: Wed, 21 Dec 2011 11:11:36 -0500 From: Christoph Hellwig Subject: Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code Message-ID: <20111221161136.GA7001@infradead.org> References: <1324426062-21505-1-git-send-email-david@fromorbit.com> <1324426062-21505-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1324426062-21505-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote: > From: Dave Chinner > > When finding the longest extent in an AG, we read the value directly > out of the AGF buffer without endian conversion. This will give an > incorrect length, resulting in FITRIM operations potentially not > trimming everything that it should. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs