public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Paul Anderson <pha@umich.edu>,
	Sean Thomas Caron <scaron@umich.edu>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate
Date: Fri, 23 Dec 2011 11:58:15 -0600	[thread overview]
Message-ID: <20111223175815.GU29840@sgi.com> (raw)
In-Reply-To: <20111218154955.GB17626@infradead.org>

On Sun, Dec 18, 2011 at 10:49:55AM -0500, Christoph Hellwig wrote:
> If the writeback code writes back an inode because it has expired we currently
> use the non-blockin ->write_inode path.  This means any inode that is pinned
> is skipped.  With delayed logging and a workload that has very little log
> traffic otherwise it is very likely that an inode that gets constantly
> written to is always pinned, and thus we keep refusing to write it.  The VM
> writeback code at that point redirties it and doesn't try to write it again
> for another 30 seconds.  This means under certain scenarious time based
> metadata writeback never happens.
> 
> Fix this by calling into xfs_log_inode for kupdate in addition to data
> integrity syncs, and thus transfer the inode to the log ASAP.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfs/fs/xfs/xfs_super.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_super.c	2011-12-14 05:33:07.193262189 -0800
> +++ xfs/fs/xfs/xfs_super.c	2011-12-14 05:38:56.108038623 -0800
> @@ -905,7 +884,7 @@ xfs_fs_write_inode(

I could not reproduce a situation where this was called with for_kupdate
set and the inode was pinned for very long.  I'm curious if there was an
easy workload to reproduce this.

>  	if (!ip->i_update_core)
>  		return 0;
>  
> -	if (wbc->sync_mode == WB_SYNC_ALL) {
> +	if (wbc->sync_mode == WB_SYNC_ALL || wbc->for_kupdate) {

It looks to me that this is the relevant codepath:

       bdi_writeback_thread .or. bdi_forker_thread
         wb_do_writeback
           wb_check_old_data_flush
             wb_writeback
               writeback_sb_inodes
                 writeback_single_inode
                   write_inode
                     .write_inode
                       xfs_fs_write_inode

AFAICS the only place that for_kupdate is set is in
wb_check_old_data_flush.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2011-12-23 17:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111218154936.GA17626@infradead.org>
2011-12-18 15:49 ` [PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate Christoph Hellwig
2011-12-20 21:19   ` Dave Chinner
2011-12-23 15:55   ` Mark Tinguely
2011-12-23 17:58   ` Ben Myers [this message]
2011-12-28 21:35   ` Hans-Peter Jansen
2011-12-28 21:39     ` Christoph Hellwig
2011-12-18 15:50 ` [PATCH 2/2] xfs: log all dirty inodes in xfs_fs_sync_fs Christoph Hellwig
2011-12-18 20:03   ` Sean Thomas Caron
2011-12-18 20:09     ` Christoph Hellwig
2011-12-18 22:17   ` Dave Chinner
2011-12-18 22:32     ` Christoph Hellwig
2011-12-20 20:08   ` [PATCH 2/2 v2] " Christoph Hellwig
2011-12-20 21:21     ` Dave Chinner
2011-12-23 15:55     ` Mark Tinguely
2011-12-23 21:47     ` Ben Myers
2011-12-26 12:13       ` Dave Chinner
2011-12-29 15:42         ` Ben Myers
2011-12-29 21:44           ` Dave Chinner
2012-01-03 15:48             ` Mark Tinguely
2011-12-21 17:40 ` sync fixes Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111223175815.GU29840@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=pha@umich.edu \
    --cc=scaron@umich.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox