Re: [PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate

Dave Chinner
2011-12-20T21:19:11Z

On Sun, Dec 18, 2011 at 10:49:55AM -0500, Christoph Hellwig wrote:
> If the writeback code writes back an inode because it has expired we currently
> use the non-blockin ->write_inode path. This means any inode that is pinned
> is skipped. With delayed logging and a workload that has very little log
> traffic otherwise it is very likely that an inode that gets constantly
> written to is always pinned, and thus we keep refusing to write it. The VM
> writeback code at that point redirties it and doesn't try to write it again
> for another 30 seconds. This means under certain scenarious time based
> metadata writeback never happens.
>
> Fix this by calling into xfs_log_inode for kupdate in addition to data
> integrity syncs, and thus transfer the inode to the log ASAP.

Makes sense.

> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com