From: Christoph Hellwig <hch@infradead.org>
To: Jeremy Sanders <jeremy@jeremysanders.net>
Cc: linux-xfs@oss.sgi.com
Subject: Re: bug in fs/xfs/xfs_aops.c:959! (kernel 3.1.5)
Date: Wed, 28 Dec 2011 12:16:43 -0500 [thread overview]
Message-ID: <20111228171643.GA18895@infradead.org> (raw)
In-Reply-To: <jcn0ip$hsk$1@dough.gmane.org>
On Mon, Dec 19, 2011 at 09:36:24AM +0000, Jeremy Sanders wrote:
> Hello - this was just produced in kernel 3.1.5 (Fedora 16, x86-64,
> kernel-3.1.5-1.fc16.x86_64).
Line 959 in 3.1.5 is this:
bh = head = page_buffers(page);
page_buffers expands to:
#define page_buffers(page) \
({ \
BUG_ON(!PagePrivate(page)); \
((struct buffer_head *)page_private(page)); \
})
so what we got here is a page without buffers. Very odd.
[<ffffffff8111dec7>] __writepage+0x17/0x40
[<ffffffff8111e32d>] write_cache_pages+0x20d/0x460
[<ffffffff8111e5ca>] generic_writepages+0x4a/0x70
[<ffffffffa02eb8fd>] xfs_vm_writepages+0x4d/0x60 [xfs]
[<ffffffff8111f8d1>] do_writepages+0x21/0x40
[<ffffffff81198af9>] writeback_single_inode+0x149/0x3e0
[<ffffffff81198f30>] writeback_sb_inodes+0x1a0/0x240
[<ffffffff8119906e>] __writeback_inodes_wb+0x9e/0xd0
[<ffffffff8119a25b>] wb_writeback+0x25b/0x340
[<ffffffff8119a7b3>] wb_do_writeback+0x1c3/0x200
[<ffffffff8119a873>] bdi_writeback_thread+0x83/0x2a0
[<ffffffff8108ddbc>] kthread+0x8c/0xa0
[<ffffffff815d9974>] kernel_thread_helper+0x4/0x10
And this looks like an entirely normal callchain for the flusher thread.
Something must have set the page dirty without going through the normal
XFS codepath. Did you use any interesting virtualization things, or
utrace / systemtap or anything odd?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-28 17:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 9:36 bug in fs/xfs/xfs_aops.c:959! (kernel 3.1.5) Jeremy Sanders
2011-12-19 22:11 ` Dave Chinner
2011-12-20 9:54 ` Jeremy Sanders
2011-12-28 17:16 ` Christoph Hellwig [this message]
2011-12-29 11:07 ` Jeremy Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228171643.GA18895@infradead.org \
--to=hch@infradead.org \
--cc=jeremy@jeremysanders.net \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox