From: Christoph Hellwig <hch@infradead.org>
To: Hans-Peter Jansen <hpj@urpla.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Paul Anderson <pha@umich.edu>,
Sean Thomas Caron <scaron@umich.edu>,
xfs@oss.sgi.com
Subject: Re: [PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate
Date: Wed, 28 Dec 2011 16:39:46 -0500 [thread overview]
Message-ID: <20111228213946.GA23791@infradead.org> (raw)
In-Reply-To: <201112282235.57645.hpj@urpla.net>
On Wed, Dec 28, 2011 at 10:35:56PM +0100, Hans-Peter Jansen wrote:
> On Sunday 18 December 2011, 16:49:55 Christoph Hellwig wrote:
> > If the writeback code writes back an inode because it has expired we
> > currently use the non-blockin ->write_inode path. This means any
> > inode that is pinned is skipped. With delayed logging and a workload
> > that has very little log traffic otherwise it is very likely that an
> > inode that gets constantly written to is always pinned, and thus we
> > keep refusing to write it. The VM writeback code at that point
> > redirties it and doesn't try to write it again for another 30
> > seconds. This means under certain scenarious time based metadata
> > writeback never happens.
>
> Wouldn't this qualify as STABLE material then?
Yes, it does. But for something as complicated as XFS I'm not going to
do a simple Cc: to stable but will apply each patch individually and do
explicit testing of the backport.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-12-28 21:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111218154936.GA17626@infradead.org>
2011-12-18 15:49 ` [PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate Christoph Hellwig
2011-12-20 21:19 ` Dave Chinner
2011-12-23 15:55 ` Mark Tinguely
2011-12-23 17:58 ` Ben Myers
2011-12-28 21:35 ` Hans-Peter Jansen
2011-12-28 21:39 ` Christoph Hellwig [this message]
2011-12-18 15:50 ` [PATCH 2/2] xfs: log all dirty inodes in xfs_fs_sync_fs Christoph Hellwig
2011-12-18 20:03 ` Sean Thomas Caron
2011-12-18 20:09 ` Christoph Hellwig
2011-12-18 22:17 ` Dave Chinner
2011-12-18 22:32 ` Christoph Hellwig
2011-12-20 20:08 ` [PATCH 2/2 v2] " Christoph Hellwig
2011-12-20 21:21 ` Dave Chinner
2011-12-23 15:55 ` Mark Tinguely
2011-12-23 21:47 ` Ben Myers
2011-12-26 12:13 ` Dave Chinner
2011-12-29 15:42 ` Ben Myers
2011-12-29 21:44 ` Dave Chinner
2012-01-03 15:48 ` Mark Tinguely
2011-12-21 17:40 ` sync fixes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228213946.GA23791@infradead.org \
--to=hch@infradead.org \
--cc=hpj@urpla.net \
--cc=pha@umich.edu \
--cc=scaron@umich.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox