From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code
Date: Fri, 6 Jan 2012 10:12:54 -0500 [thread overview]
Message-ID: <20120106151254.GA11417@infradead.org> (raw)
In-Reply-To: <20111221043638.GR29840@sgi.com>
On Tue, Dec 20, 2011 at 10:36:38PM -0600, Ben Myers wrote:
> On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > When finding the longest extent in an AG, we read the value directly
> > out of the AGF buffer without endian conversion. This will give an
> > incorrect length, resulting in FITRIM operations potentially not
> > trimming everything that it should.
>
> Looks good to me.
>
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
This is a pretty serious thing, can you send it to Linus as soon as
he takes the current pull request?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-06 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 0:07 [PATCH 0/2]: xfs - fixes found with sparse checking Dave Chinner
2011-12-21 0:07 ` [PATCH 1/2] xfs: clean up minor sparse warnings Dave Chinner
2011-12-21 16:13 ` Christoph Hellwig
2011-12-21 23:59 ` Dave Chinner
2011-12-22 18:15 ` Ben Myers
2012-02-01 18:33 ` Ben Myers
2011-12-21 0:07 ` [PATCH 2/2] xfs: fix endian conversion issue in discard code Dave Chinner
2011-12-21 4:36 ` Ben Myers
2012-01-06 15:12 ` Christoph Hellwig [this message]
2012-01-06 15:38 ` Ben Myers
2011-12-21 16:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106151254.GA11417@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox