Re: [PATCH 2/2] xfs: fix endian conversion issue in discard code

Ben Myers
2012-01-06T15:38:38Z

On Fri, Jan 06, 2012 at 10:12:54AM -0500, Christoph Hellwig wrote:
> On Tue, Dec 20, 2011 at 10:36:38PM -0600, Ben Myers wrote:
> > On Wed, Dec 21, 2011 at 11:07:42AM +1100, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > When finding the longest extent in an AG, we read the value directly
> > > out of the AGF buffer without endian conversion. This will give an
> > > incorrect length, resulting in FITRIM operations potentially not
> > > trimming everything that it should.
> >
> > Looks good to me.
> >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> >
> > Reviewed-by: Ben Myers <bpm@sgi.com>
>
> This is a pretty serious thing, can you send it to Linus as soon as
> he takes the current pull request?

yep.