From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests 273: Create lost+found to pass _check_scratch_fs
Date: Wed, 11 Jan 2012 09:02:42 +1100 [thread overview]
Message-ID: <20120110220242.GB24410@dastard> (raw)
In-Reply-To: <1326213469-22687-2-git-send-email-guaneryu@gmail.com>
On Wed, Jan 11, 2012 at 12:37:49AM +0800, Eryu Guan wrote:
> fsck.extN will complain lost+found is missing and fail 273.
> So create lost+found explicitly after removing everything in
> $SCRATCH_MNT.
I'd consider that a bug in e2fsck. Other filesystems handle missing
lost+found directories without failing, but then again it's only
these new tests that do this so fixing the tests is probably the
right thing to do here.
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> ---
> 273 | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/273 b/273
> index 2965132..9ecb2d3 100755
> --- a/273
> +++ b/273
> @@ -36,6 +36,7 @@ _cleanup()
> {
> cd /
> rm -rf $SCRATCH_MNT/* $tmp.*
> + mkdir -p $SCRATCH_MNT/lost+found
> _scratch_unmount
> }
We shouldn't be removing files from the scratch device in the
_cleanup function - if the test exits or fails, we need the corpse
to be intact for debugging. Remving $SCRATCH_MNT/* from the rm
command is what should be done here.
>
> @@ -107,6 +108,7 @@ _do_workload()
> _pid=1
>
> rm -rf $SCRATCH_MNT/*
> + mkdir -p $SCRATCH_MNT/lost+found
And rather than doing this, the test should put all it's files in a
known location on the $SCRATCH_MNT and just remove that. e.g:
WORK_DIR="$SCRATCH_MNT/$seq"
....
rm -rf $WORKDIR
....
The same fixes are required for 274 and 275 as well.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-01-10 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:37 [PATCH] xfstests 271: use xfs_io to truncate file instead of truncate(1) Eryu Guan
2012-01-10 16:37 ` [PATCH] xfstests 273: Create lost+found to pass _check_scratch_fs Eryu Guan
2012-01-10 22:02 ` Dave Chinner [this message]
2012-01-12 17:24 ` Eryu Guan
2012-01-11 11:46 ` [PATCH] xfstests 271: use xfs_io to truncate file instead of truncate(1) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110220242.GB24410@dastard \
--to=david@fromorbit.com \
--cc=guaneryu@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox