From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q0B9tMMA152421 for ; Wed, 11 Jan 2012 03:55:26 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id PE4HgzhW97eVMo9s for ; Wed, 11 Jan 2012 01:55:20 -0800 (PST) Date: Wed, 11 Jan 2012 04:55:14 -0500 From: Christoph Hellwig Subject: Re: Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"? Message-ID: <20120111095513.GA26958@infradead.org> References: <20120102213706.GQ23662@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120102213706.GQ23662@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: linux-xfs@oss.sgi.com, Michael Lueck On Tue, Jan 03, 2012 at 08:37:06AM +1100, Dave Chinner wrote: > xfs: handle kmalloc failure when reading attrs > > From: Dave Chinner > > xfsdump uses for a large buffer for extended attributes, which has a > kmalloc'd shadow buffer in the kernel. This can fail after the > system has been running for some time as it is a high order > allocation. Convert this to a vmalloc so that it doesn't require > contiguous memory and so won't randomly fail while xfsdump is > running. I think this should use kmalloc for allocation smaller than a page to avoid the vmalloc overhead for the usual case of small attributes. Also the fs/xattr.c code for the normal xattr system calls needs the same treatment. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs