From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q0BAEUPA153815 for ; Wed, 11 Jan 2012 04:14:31 -0600 Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id mpnfCrTUek70jGNs for ; Wed, 11 Jan 2012 02:14:29 -0800 (PST) Date: Wed, 11 Jan 2012 21:14:27 +1100 From: Dave Chinner Subject: Re: Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"? Message-ID: <20120111101426.GI24410@dastard> References: <20120102213706.GQ23662@dastard> <20120111095513.GA26958@infradead.org> <20120111100316.GH24410@dastard> <20120111100412.GA1538@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120111100412.GA1538@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: linux-xfs@oss.sgi.com, Michael Lueck On Wed, Jan 11, 2012 at 05:04:12AM -0500, Christoph Hellwig wrote: > On Wed, Jan 11, 2012 at 09:03:16PM +1100, Dave Chinner wrote: > > Sounds like a generic kvmalloc()/kvfree() call pair is the answer > > then. i.e. if kmalloc fails, then use vmalloc()... > > If my memory serves me right that's been discussed and rejected a few > times before. Which has lead to several implementations of duplicated functionality like: - ext4_kvmalloc/ext4_kvfree - drm_malloc_ab/drm_calloc_large/drm_free_large - ceph_buffer_new/ceph_buffer_release - gfs2_alloc_sort_buffer/gfs2_free_sort_buffer - __ntfs_malloc/ntfs_free I don't think adding another two sets of identical wrappers (or open coding it) is the right thing given that it is a repeating pattern. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs