From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q0BBU2jq160730 for ; Wed, 11 Jan 2012 05:30:02 -0600 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id 5U1ZxE4cw3y5oahr for ; Wed, 11 Jan 2012 03:29:58 -0800 (PST) Received: from hch by bombadil.infradead.org with local (Exim 4.76 #1 (Red Hat Linux)) id 1RkwNS-0002sQ-8o for xfs@oss.sgi.com; Wed, 11 Jan 2012 11:29:58 +0000 Date: Wed, 11 Jan 2012 06:29:58 -0500 From: Christoph Hellwig Subject: Re: [PATCH 09/12] repair: kill check_inode_block Message-ID: <20120111112958.GA10932@infradead.org> References: <20111202174619.179530033@bombadil.infradead.org> <20111202174742.901901836@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111202174742.901901836@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com ping? On Fri, Dec 02, 2011 at 12:46:28PM -0500, Christoph Hellwig wrote: > It's a wrapper around check_aginode_block, but given that the only caller > already has the agno and agbno at hand it isn't overly useful. > > Signed-off-by: Christoph Hellwig > > Index: xfsprogs-dev/repair/dino_chunks.c > =================================================================== > --- xfsprogs-dev.orig/repair/dino_chunks.c 2011-11-14 20:04:08.847867904 +0100 > +++ xfsprogs-dev/repair/dino_chunks.c 2011-11-14 20:04:59.487867601 +0100 > @@ -72,14 +72,6 @@ check_aginode_block(xfs_mount_t *mp, > return(cnt); > } > > -int > -check_inode_block(xfs_mount_t *mp, > - xfs_ino_t ino) > -{ > - return(check_aginode_block(mp, XFS_INO_TO_AGNO(mp, ino), > - XFS_INO_TO_AGBNO(mp, ino))); > -} > - > /* > * tries to establish if the inode really exists in a valid > * inode chunk. returns number of new inodes if things are good > @@ -145,10 +137,9 @@ verify_inode_chunk(xfs_mount_t *mp, > */ > if (XFS_IALLOC_BLOCKS(mp) == 1) { > if (agbno > max_agbno) > - return(0); > - > - if (check_inode_block(mp, ino) == 0) > - return(0); > + return 0; > + if (check_aginode_block(mp, agno, agino) == 0) > + return 0; > > pthread_mutex_lock(&ag_locks[agno]); > > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs ---end quoted text--- _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs